From b6358160be09a75bb7bf364def862b9532ba575a Mon Sep 17 00:00:00 2001 From: Celeste Martinez Date: Wed, 8 Jan 2025 15:30:21 -0500 Subject: [PATCH 1/2] remove readers as nonreaders of AE paper group --- openreview/journal/group.py | 1 - 1 file changed, 1 deletion(-) diff --git a/openreview/journal/group.py b/openreview/journal/group.py index 4d4358b8b..e70b459f9 100644 --- a/openreview/journal/group.py +++ b/openreview/journal/group.py @@ -454,7 +454,6 @@ def setup_submission_groups(self, note): if not action_editors_group: action_editors_group=self.post_group(Group(id=action_editors_group_id, readers=['everyone'], - nonreaders=[authors_group_id], writers=[venue_id], signatures=[venue_id], signatories=[venue_id], From 211c05966b1ce50b33bd58107b7452d5190f28f4 Mon Sep 17 00:00:00 2001 From: Celeste Martinez Date: Thu, 9 Jan 2025 11:00:52 -0500 Subject: [PATCH 2/2] allow AEs to report archived reviewers --- .../journal/process/reviewer_report_pre_process.py | 4 ++-- tests/test_journal.py | 12 ++++++++++++ 2 files changed, 14 insertions(+), 2 deletions(-) diff --git a/openreview/journal/process/reviewer_report_pre_process.py b/openreview/journal/process/reviewer_report_pre_process.py index e748734b4..049992455 100644 --- a/openreview/journal/process/reviewer_report_pre_process.py +++ b/openreview/journal/process/reviewer_report_pre_process.py @@ -4,5 +4,5 @@ def process(client, edit, invitation): reviewer_id=edit.note.content['reviewer_id']['value'] - if not client.get_groups(id=journal.get_reviewers_id(), member=reviewer_id): - raise openreview.OpenReviewException(f'Invalid reviewer id {reviewer_id}, make sure the reviewer is part of the reviewers group') + if not client.get_groups(id=journal.get_reviewers_id(), member=reviewer_id) and not client.get_groups(id=journal.get_reviewers_archived_id(), member=reviewer_id): + raise openreview.OpenReviewException(f'Invalid reviewer id {reviewer_id}, make sure the reviewer is part of the reviewers or archived reviewers group') diff --git a/tests/test_journal.py b/tests/test_journal.py index 8e5583bdc..60dd3cfd3 100644 --- a/tests/test_journal.py +++ b/tests/test_journal.py @@ -4900,6 +4900,18 @@ def test_archived_action_editor(self, journal, openreview_client, test_client, h assert openreview_client.get_edges_count(invitation='TMLR/Reviewers/-/Pending_Reviews', tail='~David_Belanger1') == 0 assert openreview_client.get_edges_count(invitation='TMLR/Reviewers/-/Custom_Max_Papers', tail='~David_Belanger1') == 0 + # post a reviewer report about an archived reviewer TMLR/Reviewers/-/Reviewer_Report + reviewer_report = raia_client.post_note_edit(invitation=f'{venue_id}/Reviewers/-/Reviewer_Report', + signatures=['~Raia_Hadsell1'], + note=Note( + content={ + 'reviewer_id': { 'value': '~David_Belanger1' }, + 'report_reason': { 'value': ['Reviewer never submitted their review'] }, + 'comment': { 'value': 'This is a comment.' } + } + ) + ) + helpers.await_queue_edit(openreview_client, edit_id=reviewer_report['id']) ## Carlos Mondragon paper_assignment_edge = joelle_client.post_edge(openreview.api.Edge(invitation='TMLR/Reviewers/-/Assignment',