-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
demo css dynamic colour palette #210
base: main
Are you sure you want to change the base?
Conversation
Hi Scott, I added simpler selectors, and then I also changed the stroke color rule: I moved |
ede5e9f
to
5be05db
Compare
Thanks @mxposed ! This is much cleaner. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@rcannood happy to merge? |
Is this the intended look? How does it work -- does it invert the available palettes? I was really excited to open up this PR and be able to merge it, but looking at I just can't bring myself to saying it's an improvement :P I still think we simply need two separate palettes, one optimized for a light theme and one optimized for a dark one. I wouldn't invert the palette direction, but rather tone down the brightness (or shift the palette) to work well with a dark theme. Mind if I make a hard coded example? |
I agree with @rcannood although it looks a lot better for dark mode it is just not there yet. |
This is why I asked for input :) We can tone down the brightness if you like -- you just have to tell me what you want |
Another possible alternative -- I just reduced the brightness and left everything else the same. @rcannood @KaiWaldrant @mxposed thoughts? suggestions? |
Looks perfect to me |
I explored a dark color palette here. It uses the original ColorBrewer palettes to shift the palette rather than darkening the existing palettes. I'd propose switching between two different palette sets based on the current theme. Previous: Proposal: @scottgigante-immunai @mxposed Does this look visually appealing to you? |
Describe your changes
Issue ticket number and link
Closes #176
Checklist before requesting a review
I have performed a self-review of my code
Check the correct box. Does this PR contain:
Proposed changes are described in the CHANGELOG.md
CI Preview succeeds and looks good!