Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Capitalized modality names are not processed by full pipeline workflow #626

Open
KaiWaldrant opened this issue Dec 5, 2023 · 3 comments
Labels
enhancement New feature or request

Comments

@KaiWaldrant
Copy link
Collaborator

I had a Mudata where the modality name was capitalized "RNA" and the full pipeline workflow did not process the data and it was not clear as to why this happened. It only performed the process of split_mod, concat and merge.

https://production.nftower.jnj.com/orgs/JnJ-Core/workspaces/CS000253-Lysosomal-Storage-Biology/watch/53pbZSbGsmsPnr

@DriesSchaumont
Copy link
Member

@KaiWaldrant Your modality should be lowercase: rna. Because it is uppercase , it is the modality is not recognized as being supported. The data is still goes through the dataflow, but no processing is being done.

@KaiWaldrant
Copy link
Collaborator Author

@DriesSchaumont I know, that is the issue for me. I had to troubleshoot why this was not anlyizing my data. It was not clear that the modality should be lower case. Some kind of message should be thrown if nothing is analyzed and/or the conversion tool should be altered to not allow uppercase because I added the modality in the conversion pipeline.

and another question should it be case dependent ?

@DriesSchaumont
Copy link
Member

Thats another discussion. For the naming of the modalities, we follow the convention proposed by the single cell best practices. However, we could implement some functionality to customize this behavor. This needs to be discussed :)

@DriesSchaumont DriesSchaumont added the enhancement New feature or request label Dec 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants