-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor the TotalVI component to also allow running without reference #546
Comments
You mean integration of the given data and creating the reference? Sure, I can do that. Maybe other integration components lack this regime as well |
@VladimirShitov indeed it is for creating the reference, identical as we do for scvi. In addition to this, we talked last week about moving the different components for reference building and/or integration into the integrate namespace. While we would move all the reference mapping to the reference_mapping workspace. |
@ddemaeyer , you mentioned that the totalVI component is already used by someone? Should I keep the code backward compatible then and not change API? I see 2 options now:
I am in favor of option 1. |
Hey @VladimirShitov, the component is not used at the moment. This since there is a reference required to use it, which is quite difficult today since you can't make one using OP. Hence, I completely agree with option 1. |
Thanks! |
Currently the TotalVI component/pipeline requires existing reference to be loaded. We should extend the behavior to only also allow running without supplied reference.
The text was updated successfully, but these errors were encountered: