Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend return values for some natives #958

Open
NexiusTailer opened this issue Aug 8, 2024 · 0 comments
Open

Extend return values for some natives #958

NexiusTailer opened this issue Aug 8, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@NexiusTailer
Copy link
Contributor

NexiusTailer commented Aug 8, 2024

There are some natives which always return 1/true, but they could have some arguments validity checks and start to return 0/false as well to indicate it did not execute with success. Those natives are:

  • SendRconCommand/SendRconCommandf can check if the passed string is empty to return failure (just like it was made with GameTextForAll, for example)
  • UnBlockIpAddress can also check if ip_address string is empty (just like BlockIpAddress do it now)
  • SetGameModeText can return failure if the passed string is empty. Now it returns success, but gamemode text doesn't change and stays the previous set
@NexiusTailer NexiusTailer added the enhancement New feature or request label Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant