New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix approval tests #329

Open

Rune-Christensen opened this issue Oct 23, 2023 · 0 comments

Assignees

Collaborator

Rune-Christensen commented Oct 23, 2023

The approval tests started malfunctioning after changes to the version management setup.

There are a couple of problems:
approvalActualOutput points to the wrong file.
def approvalActualOutput = "approval-test-actual.txt"

the approval tests functions should be dependent on copyJarToBin instead of fatJar.

And approvaltest should be fixed, so at runtime, the scripts used, points to the current version.jar, instead of @Version@

samdion1994 self-assigned this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment