Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Selection Handling #36

Open
ghost opened this issue Jan 21, 2015 · 1 comment
Open

Selection Handling #36

ghost opened this issue Jan 21, 2015 · 1 comment

Comments

@ghost
Copy link

ghost commented Jan 21, 2015

The selection handling code in both gridview.js and graphview.js includes a lot of variables not explicitly declared with "var." While this doesn't seem to cause problems at the moment, this is probably something that should be fixed.

@ghost
Copy link
Author

ghost commented Jan 21, 2015

Also, both files make use of the line

if (selectedItem != null && selectedTile != null) {

It's within that scope that many of the aforementioned variables are first used and set. Given that the code following that scope makes use of those values, the code as it now stands is banking on the fact that that if statement will never be false.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

0 participants