Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

annotations with other/deeper beat fractions #49

Open
jefferyshivers opened this issue Feb 8, 2017 · 3 comments
Open

annotations with other/deeper beat fractions #49

jefferyshivers opened this issue Feb 8, 2017 · 3 comments
Assignees

Comments

@jefferyshivers
Copy link
Member

scholarLY needs to be able to sort annotations by exact location, and so far it is only designed to parse locations up to a basic subdivision (which in most cases is suitable). The current system works since the examples aren't too complex, but it needs to be tested further and designed to deal with more complex rhythmic schemes.

Eventually this is something that should be regtested.

@uliska
Copy link
Contributor

uliska commented Feb 8, 2017 via email

@jefferyshivers
Copy link
Member Author

3e03794 (in a new branch annotate-locations) shows the problem. Checkout that branch and compile annotate.ly, then see that the last annotation, attached to a slur on the the second of three tuplet subdivisions in the first beat, shows as 1 1/3.

Yes, that is technically correct in terms of time (as the grob spans 1/3 through 2/3 of the way through the beat), but isn't that misleading? We say beat 1 for first beats, beat 2 for second, and so on ... so we should say 2/3 for the second of three tuplet of a tuplet-subdivided beat.

@uliska
Copy link
Contributor

uliska commented Feb 9, 2017

OK, I see. But It is not a matter of parsing (and I'm pretty sure it wouldn't affect sorting by time) but rather an issue with the output formatting.

The thing is that ly:moment? is zero-based and "thinks" in terms of ratios of the whole note - instead of beats.

I don't have time to look into the code today, but I assume that I implemented a "fix" for that when displaying the beat but didn't do so on lower levels.

It's definitely something to be looked into, but on that level of output formatting.
A quick glance also pointed to util/rhythmic-location.ily in the oll-core package, but I'm not sure right now what the actual problem is.

@uliska uliska self-assigned this Feb 9, 2017
@jefferyshivers jefferyshivers changed the title parsing annotations with other/deeper beat fractions annotations with other/deeper beat fractions Mar 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants