Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to show "external" ERC20 amount in token badge #469

Open
jtrein opened this issue Sep 8, 2021 · 0 comments
Open

Add ability to show "external" ERC20 amount in token badge #469

jtrein opened this issue Sep 8, 2021 · 0 comments
Labels
enhancement New feature or request

Comments

@jtrein
Copy link
Contributor

jtrein commented Sep 8, 2021

This is an idea following on from launching the development version of Loot DAO and @jdville03 's note that we won't be able to currently display a balance amount in the token badge for an "external" ERC20 token, i.e. not tracked and managed via the DAO's ERC20 token Extension contract.

Is it possible for us to make the token badge component display the balance of an ERC20 token from the actual contract, which is not tracked by our Tribute ERC20 token Extension?

Maybe adding a render prop to render the result of a hook's (or no hook) function call to balanceOf? Or by perhaps making another similar hook/component to the one currently use?

We could add some kind of config to conditionally render the correct stuff, maybe via env var, to keep the code more generic. E.g. env var as stringified JSON SOME_UI_TOKEN_CONFIG="{"type": "external", "symbol": "AGLD"}" , or separate the env vars data.


cc: @jdville03 @sophiacodes

@jtrein jtrein added the enhancement New feature or request label Sep 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant