[style] fix orcid button alignment, less awkward intermediate-width menu #1392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sneakers-the-rat
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
currently the orcid button is out of alignment:
and on the mobile menu is has no horizontal padding. the underlines also extend too low into the neighboring item
So this pr aligns it
and since the horizontal line animation only really works on a horizontal menu, and the only time it's seen is on intermediate widths on desktops/laptops (since tablets/phones don't hover) where we would be scooting a mouse up and down, so i replaced it with a small size animation that has vertical rather than horizontal flow
and also added padding to the orcid button and prevented it from inverting color on hover since it was the only thing to do that
vertical-menu.mp4