Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REVIEW]: Flood Resilience Digital Twin: A system to enable flood risk analysis and prediction #7433

Open
editorialbot opened this issue Nov 6, 2024 · 7 comments
Assignees
Labels
review Track: 6 (ESE) Earth Sciences and Ecology

Comments

@editorialbot
Copy link
Collaborator

Submitting author: @LukeParky (Luke Parkinson)
Repository: https://github.com/GeospatialResearch/Digital-Twins
Branch with paper.md (empty if default branch): master
Version: v1.2.0
Editor: @cheginit
Reviewers: @pritamd47, @changliao1025
Archive: Pending

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/8bc2b3a97de296355fec1f243010401c"><img src="https://joss.theoj.org/papers/8bc2b3a97de296355fec1f243010401c/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/8bc2b3a97de296355fec1f243010401c/status.svg)](https://joss.theoj.org/papers/8bc2b3a97de296355fec1f243010401c)

Reviewers and authors:

Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)

Reviewer instructions & questions

@pritamd47 & @changliao1025, your review will be checklist based. Each of you will have a separate checklist that you should update when carrying out your review.
First of all you need to run this command in a separate comment to create the checklist:

@editorialbot generate my checklist

The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @cheginit know.

Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest

Checklists

@pritamd47, please create your checklist typing: @editorialbot generate my checklist

@changliao1025, please create your checklist typing: @editorialbot generate my checklist

@editorialbot
Copy link
Collaborator Author

Hello humans, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator Author

Software report:

github.com/AlDanial/cloc v 1.90  T=0.48 s (612.4 files/s, 422385.0 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
JSON                            18              0              0         136530
HTML                            83           2216            238          20677
JavaScript                      18           3991           4158           7210
Python                          53           1421           5353           4277
SVG                              1              0              0           2671
CSS                              6            198             51            824
YAML                             8             63             18            766
reStructuredText                76           3392           4631            569
Vuejs Component                  6             42             79            427
Markdown                         6             75              0            248
TeX                              1             16              0            158
Dockerfile                       2             32             28             80
TypeScript                       7             13             20             76
Bourne Shell                     3             13             11             43
Scheme                           1              0              0             28
DOS Batch                        1              8              1             26
make                             1              4              7              9
-------------------------------------------------------------------------------
SUM:                           291          11484          14595         174619
-------------------------------------------------------------------------------

Commit count by author:

  1208	Casey Li
   400	Luke Parkinson
   135	Pooja3894
   103	Pooja Khosla
    37	Rose Pearson
    22	PoojaKhosla
    13	Xander Cai
     7	GRI Admin
     5	xandercai
     4	Casey
     4	Martin
     4	Sam Thompson
     3	Angus L
     2	Martin Nguyen
     2	sli229
     1	UOCNT
     1	martin20494

@editorialbot
Copy link
Collaborator Author

Paper file info:

📄 Wordcount for paper.md is 1255

✅ The paper includes a Statement of need section

@editorialbot
Copy link
Collaborator Author

License info:

🟡 License found: GNU Affero General Public License v3.0 (Check here for OSI approval)

@editorialbot
Copy link
Collaborator Author

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

✅ OK DOIs

- 10.1016/j.envsoft.2023.105842 is OK
- 10.3390/ijerph18083952 is OK
- 10.1080/17477891.2022.2142500 is OK
- 10.1038/s41467-022-30725-6 is OK
- 10.1080/03036758.2023.2211777 is OK
- 10.1080/19475705.2018.1552630 is OK
- 10.21203/rs.3.rs-1123016/v1 is OK

🟡 SKIP DOIs

- No DOI given, and none found for title: Flood Resilience Digital Twin (FReDT)
- No DOI given, and none found for title: BG Flood
- No DOI given, and none found for title: Mā te haumaru ō ngā puna wai ō Rākaihautū ka ora m...
- No DOI given, and none found for title: Flooding Brings Deep Trouble
- No DOI given, and none found for title: Climate Change Implications for New Zealand
- No DOI given, and none found for title: Hydrological projections for New Zealand rivers un...
- No DOI given, and none found for title: Hirds.v3: High Intensity Rainfall Design System – ...
- No DOI given, and none found for title: Towards a National Digital Twin for Flood Resilien...
- No DOI given, and none found for title: Regional Flood Estimation Tool for New Zealand Par...
- No DOI given, and none found for title: Regional Flood Estimation Tool for New Zealand Par...

❌ MISSING DOIs

- None

❌ INVALID DOIs

- None

@cheginit
Copy link

cheginit commented Nov 6, 2024

👋🏼 @LukeParky, @pritamd47, @changliao1025, this is the review thread for the paper. All of our communications will happen here from now on.

As a reviewer, the first step, as mentioned in the first comment of this issue, is to create a checklist for your review by entering

@editorialbot generate my checklist

as the top of a new comment in this thread.

These checklists contain the JOSS requirements. As you go over the submission, please check any items that you feel have been satisfied. The first comment in this thread also contains links to the JOSS reviewer guidelines.

The JOSS review is different from most other journals. Our goal is to work with the authors to help them meet our criteria instead of merely passing judgment on the submission. As such, the reviewers are encouraged to submit issues and pull requests on the software repository. When doing so, please mention openjournals/joss-reviews#7433 so that a link is created to this thread (and I can keep an eye on what is happening). Please also feel free to comment and ask questions on this thread. In my experience, it is better to post comments/questions/suggestions as you come across them, instead of waiting until you've reviewed the entire package.

We aim for reviews to be completed within about 2-4 weeks. Please notify me if any of you require some more time. We can also use EditorialBot (our bot) to set automatic reminders if you know you'll be away for a known period of time.

Please don't hesitate to ping me (@cheginit) if you have any questions/concerns.

@editorialbot
Copy link
Collaborator Author

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
review Track: 6 (ESE) Earth Sciences and Ecology
Projects
None yet
Development

No branches or pull requests

2 participants