[REVIEW]: nleis.py: A Nonlinear Electrochemical Impedance Analysis Toolbox

[editorialbot]

Submitting author: @yuefan98 (Yuefan Ji)
Repository: https://github.com/yuefan98/nleis.py
Branch with paper.md (empty if default branch):
Version: v0.1
Editor: @lucydot
Reviewers: @alberto-battistel, @leeberty84
Archive: Pending

Status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/f21e419a944424a7322cd0514dc029db"><img src="https://joss.theoj.org/papers/f21e419a944424a7322cd0514dc029db/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/f21e419a944424a7322cd0514dc029db/status.svg)](https://joss.theoj.org/papers/f21e419a944424a7322cd0514dc029db)

Reviewers and authors:

Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)

Reviewer instructions & questions

@alberto-battistel & @leeberty84, your review will be checklist based. Each of you will have a separate checklist that you should update when carrying out your review.
First of all you need to run this command in a separate comment to create the checklist:

@editorialbot generate my checklist

The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @lucydot know.

✨ Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest ✨

Checklists

@alberto-battistel, please create your checklist typing: @editorialbot generate my checklist

@leeberty84, please create your checklist typing: @editorialbot generate my checklist

[editorialbot]

Hello humans, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf

[editorialbot]

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

✅ OK DOIs

- 10.1149/2.0711811jes is OK
- 10.21105/joss.02349 is OK
- 10.1016/j.ijhydene.2007.05.036 is OK
- 10.1016/j.jpowsour.2020.228742 is OK
- 10.1149/1.2055011 is OK
- 10.1149/2.0301711jes is OK
- 10.1149/1945-7111/acada7 is OK
- 10.1149/1945-7111/ad15ca is OK
- 10.1149/1945-7111/ad2596 is OK

🟡 SKIP DOIs

- No DOI given, and none found for title: Electrochemical impedance spectroscopy

❌ MISSING DOIs

- None

❌ INVALID DOIs

- None

[editorialbot]

Software report:

github.com/AlDanial/cloc v 1.90  T=0.04 s (842.8 files/s, 181080.6 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
Python                          14           1406           1924           2722
Markdown                         6            120              0            281
YAML                             4             23              7            109
TeX                              1              9              0             92
reStructuredText                 9             74            138             67
Jupyter Notebook                 1              0            865             58
DOS Batch                        1              8              1             26
make                             1              4              7              9
-------------------------------------------------------------------------------
SUM:                            37           1644           2942           3364
-------------------------------------------------------------------------------

Commit count by author:

    42	Yuefan Ji
    22	yuefan98
     3	Dan Schwartz
     3	Matt Murbach
     3	allcontributors[bot]

[editorialbot]

Paper file info:

📄 Wordcount for paper.md is 1487

✅ The paper includes a Statement of need section

[editorialbot]

License info:

✅ License found: MIT License (Valid open source OSI approved license)

[editorialbot]

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈