Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PRE REVIEW]: votess: A multi-target, GPU-capable, parallel Voronoi tessellator #7419

Open
editorialbot opened this issue Nov 1, 2024 · 13 comments
Labels
C++ CMake pre-review Python Track: 7 (CSISM) Computer science, Information Science, and Mathematics

Comments

@editorialbot
Copy link
Collaborator

Submitting author: @samridh-dev (Samridh Dev Singh)
Repository: https://github.com/samridh-dev/votess.git
Branch with paper.md (empty if default branch):
Version: v1.0.0
Editor: Pending
Reviewers: Pending
Managing EiC: Daniel S. Katz

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/6ec6dde5a3af204839779715b3d644ea"><img src="https://joss.theoj.org/papers/6ec6dde5a3af204839779715b3d644ea/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/6ec6dde5a3af204839779715b3d644ea/status.svg)](https://joss.theoj.org/papers/6ec6dde5a3af204839779715b3d644ea)

Author instructions

Thanks for submitting your paper to JOSS @samridh-dev. Currently, there isn't a JOSS editor assigned to your paper.

@samridh-dev if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). You can search the list of people that have already agreed to review and may be suitable for this submission.

Editor instructions

The JOSS submission bot @editorialbot is here to help you find and assign reviewers and start the main review. To find out what @editorialbot can do for you type:

@editorialbot commands
@editorialbot editorialbot added pre-review Track: 7 (CSISM) Computer science, Information Science, and Mathematics labels Nov 1, 2024
@editorialbot
Copy link
Collaborator Author

Hello human, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator Author

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

✅ OK DOIs

- 10.1017/S1743921311000378 is OK
- 10.1145/3272127.3275092 is OK
- 10.1145/235815.235821 is OK

🟡 SKIP DOIs

- No DOI given, and none found for title: CGAL User and Reference Manual
- No DOI given, and none found for title: Geogram: a programming library of geometric algori...

❌ MISSING DOIs

- 10.2172/946741 may be a valid DOI for title: VORO++: A three-dimensional Voronoi cell library i...

❌ INVALID DOIs

- https://doi.org/10.1016/j.parco.2023.102995 is INVALID because of 'https://doi.org/' prefix

@editorialbot
Copy link
Collaborator Author

Software report:

github.com/AlDanial/cloc v 1.90  T=0.77 s (75.6 files/s, 409812.3 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
C++                             25           1536            169         309445
Python                           3            136             56           1118
C/C++ Header                    14            200            170            525
Markdown                         2             80              0            282
CMake                            9             51             12            176
YAML                             2             20             42            117
TeX                              1              6              0             65
Bourne Shell                     2              5              2             54
-------------------------------------------------------------------------------
SUM:                            58           2034            451         311782
-------------------------------------------------------------------------------

Commit count by author:

   274	samridh-dev
     2	Samridh D. Singh

@editorialbot
Copy link
Collaborator Author

Paper file info:

📄 Wordcount for paper.md is 705

✅ The paper includes a Statement of need section

@editorialbot
Copy link
Collaborator Author

License info:

🟡 License found: GNU General Public License v3.0 (Check here for OSI approval)

@editorialbot
Copy link
Collaborator Author

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@editorialbot
Copy link
Collaborator Author

Five most similar historical JOSS papers:

DTCC Builder: A mesh generator for automatic, efficient, and robust mesh generation for large-scale city modeling and simulation
Submitting author: @anderslogg
Handling editor: @crvernon (Active)
Reviewers: @ifthompson, @ipadjen
Similarity score: 0.7248

Efficient Polyhedral Gravity Modeling in Modern C++ and Python
Submitting author: @schuhmaj
Handling editor: @dfm (Active)
Reviewers: @mikegrudic, @santisoler
Similarity score: 0.7121

VAST: the Void Analysis Software Toolkit
Submitting author: @kadglass
Handling editor: @dfm (Active)
Reviewers: @changhoonhahn, @lavaux
Similarity score: 0.7046

SiSyPHE: A Python package for the Simulation of Systems of interacting mean-field Particles with High Efficiency
Submitting author: @antoinediez
Handling editor: @pdebuyl (Active)
Reviewers: @lorenzo-rovigatti, @junghans
Similarity score: 0.6967

BoxKit: A Python library to manage analysis of block-structured simulation datasets
Submitting author: @akashdhruv
Handling editor: @kellyrowland (Active)
Reviewers: @rvg296, @Abinashbunty
Similarity score: 0.6966

⚠️ Note to editors: If these papers look like they might be a good match, click through to the review issue for that paper and invite one or more of the authors before considering asking the reviewers of these papers to review again for JOSS.

@danielskatz
Copy link

@samridh-dev - thanks for your submission. Our LOC counter shows 300k LOC of C++ in your repository. It seems likely that this is not all your code, but that you are including code from other packages. Can you help me understand what part of this is your code that we should be reviewing, and what is preexisting code that we would not review?

@samridh-dev
Copy link

samridh-dev commented Nov 1, 2024 via email

@danielskatz
Copy link

Which part of the code (meaning which directories) should be counted and reviewed?

@samridh-dev
Copy link

samridh-dev commented Nov 1, 2024 via email

@danielskatz
Copy link

👋 @Kevin-Mattheus-Moerman - Would you be interested in editing (or reviewing) this submission?

@Kevin-Mattheus-Moerman
Copy link
Member

Happy to do either but probably editing is best.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C++ CMake pre-review Python Track: 7 (CSISM) Computer science, Information Science, and Mathematics
Projects
None yet
Development

No branches or pull requests

4 participants