-
-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PRE REVIEW]: votess: A multi-target, GPU-capable, parallel Voronoi tessellator #7419
Comments
Hello human, I'm @editorialbot, a robot that can help you with some common editorial tasks. For a list of things I can do to help you, just type:
For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:
|
|
Software report:
Commit count by author:
|
Paper file info: 📄 Wordcount for ✅ The paper includes a |
License info: 🟡 License found: |
Five most similar historical JOSS papers: DTCC Builder: A mesh generator for automatic, efficient, and robust mesh generation for large-scale city modeling and simulation Efficient Polyhedral Gravity Modeling in Modern C++ and Python VAST: the Void Analysis Software Toolkit SiSyPHE: A Python package for the Simulation of Systems of interacting mean-field Particles with High Efficiency BoxKit: A Python library to manage analysis of block-structured simulation datasets |
@samridh-dev - thanks for your submission. Our LOC counter shows 300k LOC of C++ in your repository. It seems likely that this is not all your code, but that you are including code from other packages. Can you help me understand what part of this is your code that we should be reviewing, and what is preexisting code that we would not review? |
Hi, Do not review the test cases since I believe that is auto generated and is probably why the code is around 300k. The main source code is around 30k instead,
…________________________________
From: Daniel S. Katz ***@***.***>
Sent: Friday, November 1, 2024 2:37 PM
To: openjournals/joss-reviews ***@***.***>
Cc: Singh, Samridh Dev (Sam) ***@***.***>; Mention ***@***.***>
Subject: Re: [openjournals/joss-reviews] [PRE REVIEW]: votess: A multi-target, GPU-capable, parallel Voronoi tessellator (Issue #7419)
Caution: External Email
@samridh-dev<https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_samridh-2Ddev&d=DwMFaQ&c=HUrdOLg_tCr0UMeDjWLBOM9lLDRpsndbROGxEKQRFzk&r=HWASZq6TcwVwkJpqA8x6LcNTa2Fa6N92aMe4xwgG2Pk&m=RR8jWEjt36nazbPfi_IG0ypnnRRueTk9Ny6Jy1ZbvwftxJHrlat4h-oDjfyVKbql&s=GhQZHdOT8UETA6Lxeh4MKu9-CLt0K80Dz8Pp_6ru1gM&e=> - thanks for your submission. Our LOC counter shows 300k LOC of C++ in your repository. It seems likely that this is not all your code, but that you are including code from other packages. Can you help me understand what part of this is your code that we should be reviewing, and what is preexisting code that we would not review?
—
Reply to this email directly, view it on GitHub<https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_openjournals_joss-2Dreviews_issues_7419-23issuecomment-2D2452477088&d=DwMFaQ&c=HUrdOLg_tCr0UMeDjWLBOM9lLDRpsndbROGxEKQRFzk&r=HWASZq6TcwVwkJpqA8x6LcNTa2Fa6N92aMe4xwgG2Pk&m=RR8jWEjt36nazbPfi_IG0ypnnRRueTk9Ny6Jy1ZbvwftxJHrlat4h-oDjfyVKbql&s=QFaSsYCinn81DlOjemVKQ7exoIn7JhpKP5YnZrB-L2w&e=>, or unsubscribe<https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_notifications_unsubscribe-2Dauth_BASUXMH7T2AJJM3XILFCLW3Z6PJ53AVCNFSM6AAAAABRA2XNGCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINJSGQ3TOMBYHA&d=DwMFaQ&c=HUrdOLg_tCr0UMeDjWLBOM9lLDRpsndbROGxEKQRFzk&r=HWASZq6TcwVwkJpqA8x6LcNTa2Fa6N92aMe4xwgG2Pk&m=RR8jWEjt36nazbPfi_IG0ypnnRRueTk9Ny6Jy1ZbvwftxJHrlat4h-oDjfyVKbql&s=Q87KAJ9nF0zxoaN14uosuES87GE7Cy6DU5_8y_Leygs&e=>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
This email was sent from outside Grinnell College. Treat attachments and links with caution. If this message looks suspicious, use the report phish button.
|
Which part of the code (meaning which directories) should be counted and reviewed? |
Only the src/ and include/ directories should be reviewed.
…________________________________
From: Daniel S. Katz ***@***.***>
Sent: Friday, November 1, 2024 2:40 PM
To: openjournals/joss-reviews ***@***.***>
Cc: Singh, Samridh Dev (Sam) ***@***.***>; Mention ***@***.***>
Subject: Re: [openjournals/joss-reviews] [PRE REVIEW]: votess: A multi-target, GPU-capable, parallel Voronoi tessellator (Issue #7419)
Caution: External Email
Which part of the code (meaning which directories) should be counted and reviewed?
—
Reply to this email directly, view it on GitHub<https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_openjournals_joss-2Dreviews_issues_7419-23issuecomment-2D2452481438&d=DwMFaQ&c=HUrdOLg_tCr0UMeDjWLBOM9lLDRpsndbROGxEKQRFzk&r=HWASZq6TcwVwkJpqA8x6LcNTa2Fa6N92aMe4xwgG2Pk&m=-aaMhHOxo5yvCVoZ5UrQnXvK2aQNvHg-evuVsMfPlVR84AHQQ1hSQ2fRbDlYqI2N&s=Xyz1Hu-diNlcEwif1JwFuq2d77GSi_LiP2S1xdDGPn4&e=>, or unsubscribe<https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_notifications_unsubscribe-2Dauth_BASUXMCWGEMZDXWK5BLBUD3Z6PKK7AVCNFSM6AAAAABRA2XNGCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINJSGQ4DCNBTHA&d=DwMFaQ&c=HUrdOLg_tCr0UMeDjWLBOM9lLDRpsndbROGxEKQRFzk&r=HWASZq6TcwVwkJpqA8x6LcNTa2Fa6N92aMe4xwgG2Pk&m=-aaMhHOxo5yvCVoZ5UrQnXvK2aQNvHg-evuVsMfPlVR84AHQQ1hSQ2fRbDlYqI2N&s=iKGYgY8TZi0IyTgGfmyrT586cI4uoFx0teG4ezPF3P4&e=>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
This email was sent from outside Grinnell College. Treat attachments and links with caution. If this message looks suspicious, use the report phish button.
|
👋 @Kevin-Mattheus-Moerman - Would you be interested in editing (or reviewing) this submission? |
Happy to do either but probably editing is best. |
Submitting author: @samridh-dev (Samridh Dev Singh)
Repository: https://github.com/samridh-dev/votess.git
Branch with paper.md (empty if default branch):
Version: v1.0.0
Editor: Pending
Reviewers: Pending
Managing EiC: Daniel S. Katz
Status
Status badge code:
Author instructions
Thanks for submitting your paper to JOSS @samridh-dev. Currently, there isn't a JOSS editor assigned to your paper.
@samridh-dev if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). You can search the list of people that have already agreed to review and may be suitable for this submission.
Editor instructions
The JOSS submission bot @editorialbot is here to help you find and assign reviewers and start the main review. To find out what @editorialbot can do for you type:
The text was updated successfully, but these errors were encountered: