Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PRE REVIEW]: QuantizedSystemSolver: A discontinuous ODE system 2 solver for Julia. #7156

Closed
editorialbot opened this issue Aug 28, 2024 · 46 comments
Assignees
Labels
Julia pre-review TeX Track: 7 (CSISM) Computer science, Information Science, and Mathematics

Comments

@editorialbot
Copy link
Collaborator

editorialbot commented Aug 28, 2024

Submitting author: @mongibellili (elmongi elbellili)
Repository: https://github.com/mongibellili/QuantizedSystemSolver.jl
Branch with paper.md (empty if default branch):
Version: v1.0.1
Editor: @diehlpk
Reviewers: @joshuaeh, @lamBOOO
Managing EiC: Daniel S. Katz

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/f779f8dbd5bcd59e354eb9dddda30eac"><img src="https://joss.theoj.org/papers/f779f8dbd5bcd59e354eb9dddda30eac/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/f779f8dbd5bcd59e354eb9dddda30eac/status.svg)](https://joss.theoj.org/papers/f779f8dbd5bcd59e354eb9dddda30eac)

Author instructions

Thanks for submitting your paper to JOSS @mongibellili. Currently, there isn't a JOSS editor assigned to your paper.

@mongibellili if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). You can search the list of people that have already agreed to review and may be suitable for this submission.

Editor instructions

The JOSS submission bot @editorialbot is here to help you find and assign reviewers and start the main review. To find out what @editorialbot can do for you type:

@editorialbot commands
@editorialbot editorialbot added pre-review Track: 7 (CSISM) Computer science, Information Science, and Mathematics labels Aug 28, 2024
@editorialbot
Copy link
Collaborator Author

Hello human, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator Author

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

✅ OK DOIs

- 10.5281/zenodo.2557003 is OK
- 10.1137/141000671 is OK

🟡 SKIP DOIs

- No DOI given, and none found for title: MacroTools.jl
- No DOI given, and none found for title: SymEngine.jl
- No DOI given, and none found for title: Improving linearly implicit quantized state system...

❌ MISSING DOIs

- None

❌ INVALID DOIs

- None

@editorialbot
Copy link
Collaborator Author

Software report:

github.com/AlDanial/cloc v 1.90  T=0.32 s (487.1 files/s, 88841.7 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
Julia                          113           3139           6663          15801
JavaScript                       4            137            182            879
Markdown                        12            114              0            615
HTML                             9             52              0            272
TOML                             3             59              1            238
YAML                             7              6              9            230
TeX                              1              1              0             36
CSS                              6              1             13              6
JSON                             1              0              0              1
-------------------------------------------------------------------------------
SUM:                           156           3509           6868          18078
-------------------------------------------------------------------------------

Commit count by author:

    56	Mongi Bellili
    33	mongi bellili
    33	mongibellili
     1	Daan Huybrechs

@editorialbot
Copy link
Collaborator Author

Paper file info:

📄 Wordcount for paper.md is 656

✅ The paper includes a Statement of need section

@editorialbot
Copy link
Collaborator Author

License info:

✅ License found: MIT License (Valid open source OSI approved license)

@editorialbot
Copy link
Collaborator Author

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@editorialbot
Copy link
Collaborator Author

Five most similar historical JOSS papers:

WorldDynamics.jl: A Julia Package for Developing and Simulating Integrated Assessment Models
Submitting author: @aurorarossi
Handling editor: @fraukewiese (Active)
Reviewers: @ranocha, @StanczakDominik, @miguelraz
Similarity score: 0.7597

OpenGeoSysUncertaintyQuantification.jl: a Julia library implementing an uncertainty quantification toolbox for OpenGeoSys
Submitting author: @baxmittens
Handling editor: @kanishkan91 (Active)
Reviewers: @ziyiyin97, @dannys4
Similarity score: 0.7590

DynamicalBilliards.jl: An easy-to-use, modular and extendable Julia package for Dynamical Billiard systems in two dimensions.
Submitting author: @Datseris
Handling editor: @kyleniemeyer (Active)
Reviewers: @ahwillia
Similarity score: 0.7552

QAOA.jl: Toolkit for the Quantum and Mean-Field Approximate Optimization Algorithms
Submitting author: @timbode
Handling editor: @danielskatz (Active)
Reviewers: @babreu-ncsa, @pkairys, @Abinashbunty
Similarity score: 0.7532

DynamicOED.jl: A Julia package for solving optimum experimental design problems
Submitting author: @AlCap23
Handling editor: @diehlpk (Active)
Reviewers: @KBodolai, @joshuaeh
Similarity score: 0.7495

⚠️ Note to editors: If these papers look like they might be a good match, click through to the review issue for that paper and invite one or more of the authors before considering asking the reviewers of these papers to review again for JOSS.

@danielskatz
Copy link

👋 @mongibellili - thanks for your submission. Can I ask about the fact that your paper has three authors, but your repository shows almost entirely your commits, with one very small commit from one of the other authors?

@mongibellili
Copy link

mongibellili commented Aug 28, 2024 via email

@danielskatz
Copy link

👋 @diehlpk - Would you be able to edit this submission?

@danielskatz
Copy link

@editorialbot invite @diehlpk as editor

@editorialbot
Copy link
Collaborator Author

Invitation to edit this submission sent!

@diehlpk
Copy link
Member

diehlpk commented Aug 30, 2024

@danielskatz Yes, I will have a look in two weeks after traveling.

@danielskatz
Copy link

Can I assign it to you now?

@diehlpk
Copy link
Member

diehlpk commented Aug 30, 2024

@editorialbot add @diehlpk as editor

@editorialbot
Copy link
Collaborator Author

Assigned! @diehlpk is now the editor

@diehlpk
Copy link
Member

diehlpk commented Aug 30, 2024

Can I assign it to you now?

I assigned it right now. Starbucks WiFi seems not to be stable.

@diehlpk
Copy link
Member

diehlpk commented Sep 13, 2024

Hi @aurorarossi do you have time to review this paper?

@diehlpk
Copy link
Member

diehlpk commented Sep 13, 2024

Hi @baxmittens do you have time to review this paper?

@diehlpk
Copy link
Member

diehlpk commented Sep 13, 2024

Hi @Datseris do you have time to review this paper?

@Datseris
Copy link

Sorry, I am completely out of time.

@baxmittens
Copy link

Sorry for answering that late. I missed that email.
This is way out of my expertise so that I would decline this one.

@aurorarossi
Copy link

Sorry for taking so long to reply, but I'm not available to review this.

@diehlpk
Copy link
Member

diehlpk commented Oct 2, 2024

Hi @timbode do you have time to review this paper?

@diehlpk
Copy link
Member

diehlpk commented Oct 2, 2024

Hi @AlCap23 do you have time to review this paper?

@diehlpk
Copy link
Member

diehlpk commented Oct 2, 2024

hi @joshuaeh do you have time to review this paper?

@joshuaeh
Copy link

joshuaeh commented Oct 2, 2024

hi @joshuaeh do you have time to review this paper?

Sure, I can

@diehlpk
Copy link
Member

diehlpk commented Oct 2, 2024

@editorialbot add @joshuaeh as reviewer

@editorialbot
Copy link
Collaborator Author

@joshuaeh added to the reviewers list!

@diehlpk
Copy link
Member

diehlpk commented Oct 16, 2024

@mongibellili could you please recommend some potential reviewers?

@mongibellili
Copy link

Sure, I searched for all with "julia" and "numerical analysis", and removed those working on many other specific fields. I found these reviewers:
-Edenhofer
-rafaelbailo
-DanielVandH
-lucaferranti
-lamBOOO
-ManuelBehrendt
-vlc1
-victorapm
-dannys4
-RahulSundar
-mvaldes
-cmsmlab
-EdwardBerman
-simone-silvestri
-ChrisRackauckas
-josemanuel22
-ajinkyakadu
-sandreza
-ziyixi
-hemanthgrylls
-joeybernard
-mseri

@diehlpk
Copy link
Member

diehlpk commented Oct 18, 2024

Hi @Edenhofer do you have time to review this paper?

@diehlpk
Copy link
Member

diehlpk commented Oct 18, 2024

Hi @rafaelbailo do you have time to review this paper?

@diehlpk
Copy link
Member

diehlpk commented Oct 18, 2024

Hi @DanielVandH do you have time to review this paper?

@rafaelbailo
Copy link

Sorry @diehlpk, I don't have time at the moment.

@Edenhofer
Copy link

Unfortunately, I must decline to review the submission. I do not think I have the necessary expertise in the area of the submission to adequately evaluate it.

@DanielVandH
Copy link

Sorry for the late reply. Unfortunately I do not have the time currently.

@diehlpk
Copy link
Member

diehlpk commented Nov 1, 2024

Hi @lucaferranti do you have time to review this paper?

@diehlpk
Copy link
Member

diehlpk commented Nov 1, 2024

Hi @lamBOOO do you have time to review this paper?

@diehlpk
Copy link
Member

diehlpk commented Nov 1, 2024

Hi @ManuelBehrendt do you have time to review this paper?

@lamBOOO
Copy link

lamBOOO commented Nov 5, 2024

Hi @lamBOOO do you have time to review this paper?

Yes, I can do that.

@diehlpk
Copy link
Member

diehlpk commented Nov 6, 2024

@editorialbot add @lamBOOO as reviewer

@editorialbot
Copy link
Collaborator Author

@lamBOOO added to the reviewers list!

@diehlpk
Copy link
Member

diehlpk commented Nov 6, 2024

@joshuaeh, @lamBOOO thanks for agreeing to review.

I will start the review soon.

@diehlpk
Copy link
Member

diehlpk commented Nov 6, 2024

@editorialbot start review

@editorialbot
Copy link
Collaborator Author

OK, I've started the review over in #7434.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Julia pre-review TeX Track: 7 (CSISM) Computer science, Information Science, and Mathematics
Projects
None yet
Development

No branches or pull requests