Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenFF Theory Benchmarking Sets do not use correct OpenFF "default" QCSpecification #126

Open
trevorgokey opened this issue Aug 8, 2020 · 1 comment

Comments

@trevorgokey
Copy link
Collaborator

trevorgokey commented Aug 8, 2020

The following datasets use the "default" name for its only QCSpecification, but this name is, for now, strictly reserved for b3lyp-d3bj/dzvp:

TorsionDriveDataset OpenFF Theory Benchmarking Set B3LYP-D3BJ def2-TZVP v1.0
TorsionDriveDataset OpenFF Theory Benchmarking Set B3LYP-D3BJ def2-TZVPD v1.0
TorsionDriveDataset OpenFF Theory Benchmarking Set B3LYP-D3BJ def2-TZVPP v1.0

These datasets should be resubmitted with the standard spec (v1.1). If each set has the same molecule input, then they should be collapsed into a single dataset. If it is desirable to keep the datasets separate, then all should be resubmitted with the proper default spec, and their associated auxilliary model.

Also, the original input input_json had a description field in each molecule. Did @hyejang want this information in the data? It appears it did not transfer during submission. Finally, likely of less importance, the entry indices were changed from torsion driven smiles to stringified integers.

@dotsdl
Copy link
Member

dotsdl commented Aug 25, 2020

Ah, this is something I didn't catch as the reviewer. Apologies all. I will take this one on and create a new dataset that subsumes these multiple specs into a single submission for @hyejang.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants