You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The Topology.from_openmm() and Topology.from_mdtraj() methods' unique_molecules argument is currently optional, but if None is supplied we manually raise a custom error. It should be a regular positional argument. This would make it more obvious to users that it is, in fact, required. Unfortunately this is a breaking change. We should make this change the next time we make a breaking release.
The text was updated successfully, but these errors were encountered:
The OpenMM Topology object currently supports bond orders and there is an issue to add formal charges. If these are present, unique molecules can be perceived from the Topology directly without the need to manually specify them. This was supposed to happen much sooner, and can be accelerated if needed.
I'd argue that we don't need to change the behavior, but we should try to get OpenMM to prioritize adding formal charges and bond orders (compatible with OpenFF) where possible.
@mattwthompson If it were a higher-value change I'd overlook the fact that it's at the benign end of the "breaking" scale. But it might still technically break someone's Topology subclass, or do something that we haven't anticipated. And since the gain is so marginal I'd rather have this wait until an API breaking release is scheduled.
The
Topology.from_openmm()
andTopology.from_mdtraj()
methods'unique_molecules
argument is currently optional, but ifNone
is supplied we manually raise a custom error. It should be a regular positional argument. This would make it more obvious to users that it is, in fact, required. Unfortunately this is a breaking change. We should make this change the next time we make a breaking release.The text was updated successfully, but these errors were encountered: