Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add center-of-mass motion remover in OpenMM export #1133

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Add center-of-mass motion remover in OpenMM export #1133

wants to merge 1 commit into from

Conversation

mattwthompson
Copy link
Member

Description

Resolves #1127

Checklist

  • Add tests
  • Lint
  • Update docstrings

@codecov Codecov
Copy link

codecov bot commented Jan 8, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.71%. Comparing base (d283069) to head (d279628).

Additional details and impacted files

@mattwthompson
Copy link
Member Author

Need to provide a backdoor to get the regression tests to pass. I think this would involve including the new "force" as an acceptable difference

Relates to #1101 but is not dependent on it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

(Request) Add option to add CMMotionRemover to OpenMM systems
1 participant
@mattwthompson