feat: 5586 - OxF filter for term searches #5637
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Impacted files: * `category_product_query.dart`: refactored with new `productType` parameter * `keywords_product_query.dart`: refactored with new `productType` parameter * `paged_product_query.dart`: refactored with new `productType` parameter * `paged_search_product_query.dart`: refactored with new `productType` parameter * `paged_to_be_completed_product_query.dart`: refactored with new `productType` parameter * `paged_user_product_query.dart`: refactored with new `productType` parameter * `product_list.dart`: refactored with new `productType` parameter * `product_query.dart`: added a "get label" method for `ProductType` * `search_field.dart`: displayed the new optional "additional filter" (e.g. OxF) * `search_helper.dart`: added a new optional "additional filter" * `search_product_helper.dart`: new "product type filter" widget * `summary_card.dart`: minor "productType" fix * `user_preferences_account.dart`: added "productType.food" to user page counts * `user_preferences_contribute.dart`: added "productType.food" to "to be completed" products
teolemon
added
🧴 Open Beauty Facts
|
Agree with the first 3 points, on 4th, I'd like to try text first. You could have chips instead of a big pill so that we can overflow on very small screens. |
teolemon
approved these changes
Sep 27, 2024
|
Thank you @teolemon for your review! I'm about to transform somehow the pending questions into issues. Please keep in mind that we still cannot edit non-food products - that would probably create food products from scratch. |
This was referenced Sep 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
user_preferences_account.dart,user_preferences_contribute.dart)search_product_helper.dart)product_query.dart)product_query.dart)Screenshots
Part of
Impacted files
category_product_query.dart: refactored with newproductTypeparameterkeywords_product_query.dart: refactored with newproductTypeparameterpaged_product_query.dart: refactored with newproductTypeparameterpaged_search_product_query.dart: refactored with newproductTypeparameterpaged_to_be_completed_product_query.dart: refactored with newproductTypeparameterpaged_user_product_query.dart: refactored with newproductTypeparameterproduct_list.dart: refactored with newproductTypeparameterproduct_query.dart: added a "get label" method forProductTypesearch_field.dart: displayed the new optional "additional filter" (e.g. OxF)search_helper.dart: added a new optional "additional filter"search_product_helper.dart: new "product type filter" widgetsummary_card.dart: minor "productType" fixuser_preferences_account.dart: added "productType.food" to user page countsuser_preferences_contribute.dart: added "productType.food" to "to be completed" products