Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix golden tests, or understand why/how they fail #691

Closed
monsieurtanuki opened this issue Nov 25, 2021 · 1 comment · Fixed by #692
Closed

Fix golden tests, or understand why/how they fail #691

monsieurtanuki opened this issue Nov 25, 2021 · 1 comment · Fixed by #692
Assignees
@monsieurtanuki
Labels
✅ task

Comments

@monsieurtanuki
Copy link
Contributor

monsieurtanuki commented Nov 25, 2021 •
edited
Loading

cf. #679 #683 #689
@monsieurtanuki
Copy link
Contributor Author

The problem comes from #679, where I've explicitly added the bottom navigation bar in some pages, e.g. in UserPreferencesPage.
And the golden screenshots were created from the old version of UserPreferencesPage, without bottom navigation bar (the home page displayed UserPreferencesPage plus the bottom bar).
I'm about to PR.

monsieurtanuki added a commit to monsieurtanuki/smooth-app that referenced this issue Nov 25, 2021
@monsieurtanuki
fix: openfoodfacts#691 - regenerated golden screenshots for profile w…
123903b 
…ith bottom bar

Using `flutter test --update-goldens`

Impacted files:
* `user_preferences_page-blue-dark.png`
* `user_preferences_page-blue-light.png`
* `user_preferences_page-brown-dark.png`
* `user_preferences_page-brown-light.png`
* `user_preferences_page-green-dark.png`
* `user_preferences_page-green-light.png`
@monsieurtanuki monsieurtanuki linked a pull request Nov 25, 2021 that will close this issue
fix: #691 - regenerated golden screenshots for profile with bottom bar #692
Merged
monsieurtanuki added a commit that referenced this issue Nov 25, 2021
@monsieurtanuki
fix: #691 - regenerated golden screenshots for profile with bottom bar (
85970d9 
#692)

Using `flutter test --update-goldens`

Impacted files:
* `user_preferences_page-blue-dark.png`
* `user_preferences_page-blue-light.png`
* `user_preferences_page-brown-dark.png`
* `user_preferences_page-brown-light.png`
* `user_preferences_page-green-dark.png`
* `user_preferences_page-green-light.png`
@monsieurtanuki monsieurtanuki self-assigned this Nov 25, 2021
@github-actions github-actions bot mentioned this issue Jan 15, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@monsieurtanuki monsieurtanuki

Labels
✅ task
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: #691 - regenerated golden screenshots for profile with bottom bar monsieurtanuki/smooth-app
1 participant
@monsieurtanuki