Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

We should not show the nudge for nutrition on cosmetics #5665

Closed
teolemon opened this issue Oct 4, 2024 · 4 comments · Fixed by #5674
Closed

We should not show the nudge for nutrition on cosmetics #5665

teolemon opened this issue Oct 4, 2024 · 4 comments · Fixed by #5674
Assignees
@monsieurtanuki
Labels
🧴 Open Beauty Facts Please see this proposal: https://github.com/openfoodfacts/smooth-app/discussions/1378 📸 Open Products Facts OxF 🎯 P1 🥫 Product page

Comments

@teolemon
Copy link
Member

teolemon commented Oct 4, 2024

What

We should not show the nudge for nutrition on cosmetics
Screenshot_20241004-134108.png
@teolemon teolemon added 🥫 Product page 🧴 Open Beauty Facts Please see this proposal: https://github.com/openfoodfacts/smooth-app/discussions/1378 📸 Open Products Facts OxF labels Oct 4, 2024
@github-project-automation github-project-automation bot moved this to To Discuss & Validate in 🧴 Open Beauty Facts Oct 4, 2024
@monsieurtanuki
Copy link
Contributor

@teolemon Not sure if we invent that nudge. I think KP send it.
Of course we can deactivate it just on our side too.

@teolemon
Copy link
Member Author

teolemon commented Oct 4, 2024

I thought some of it was hard coded, I will file server side then
Cc @stephanegigandet

@monsieurtanuki
Copy link
Contributor

I have to double-check. I think what is hard-coded in Smoothie is "when you see 'action_nutrition', display a button like this".
We may consider too that the server shouldn't send the 'action_nutrition' message.

@monsieurtanuki
Copy link
Contributor

@teolemon @stephanegigandet There are 2 cases in Smoothie where we display that "add nutrition facts" button:

  • 'add_nutrition_facts' as a Knowledge Panel Action
  • 'en:nutrition-facts-to-be-completed' as a product state
  • (would need the barcode to confirm)

@monsieurtanuki monsieurtanuki self-assigned this Oct 8, 2024
@monsieurtanuki monsieurtanuki mentioned this issue Oct 8, 2024
Merged
@github-project-automation github-project-automation bot moved this from To Discuss & Validate to Done in 🧴 Open Beauty Facts Oct 20, 2024
@github-project-automation github-project-automation bot moved this from 💬 To discuss and validate to 🎊 Done in 🤳🥫 The Open Food Facts mobile app (Android & iOS) Oct 20, 2024
@github-project-automation github-project-automation bot moved this from To do to Done in 📸 Open Products Facts Oct 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@monsieurtanuki monsieurtanuki

Labels
🧴 Open Beauty Facts Please see this proposal: https://github.com/openfoodfacts/smooth-app/discussions/1378 📸 Open Products Facts OxF 🎯 P1 🥫 Product page
Projects
🎯 Very high impact issues
Archived in project
📸 Open Products Facts
Archived in project
🤳🥫 The Open Food Facts mobile app (Android & iOS)
Archived in project
🧴 Open Beauty Facts
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: 5665 - display "add nutrition facts" button only for relevant types monsieurtanuki/smooth-app
2 participants
@teolemon @monsieurtanuki