Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feedback requested] Improved screen to input Basic Details #5512

Open
g123k opened this issue Jul 26, 2024 · 5 comments
Open

[Feedback requested] Improved screen to input Basic Details #5512

g123k opened this issue Jul 26, 2024 · 5 comments
Labels
✏️ Editing - Basic info input ✏️ Editing - Text fields ✏️ Editing Many products are incomplete and don't have Nutri-Score, Eco-Score…so editing is important for users ✨ 2024 the big redesign

Comments

@g123k
Copy link
Collaborator

g123k commented Jul 26, 2024

Hi everyone,

I've redesigned the Basic Details page.

There are two main goals:

  • Simplify the translation mechanism
  • Simplify the input of brands (and to change the order)

More specifically, for translations, the idea is to have a list of all of them.
A flag if a photo is also available (green OK / orange missing)

Artboard

@October-Food-Facts
Copy link

October-Food-Facts commented Jul 28, 2024

So many errors. I understand that they might not be related to any changes being done here. Nonetheless, touching this subject...

"Coca-Cola Company" is not a product brand. That is a false statement.
Correct examples:
Main brands: KitKat, Prince, Milka.
Secondary brands: Nestlé, LU, Mondelēz.

In spelling terms, the correct way to write is with a space in between the values and units (always "100 g," never "100g"). A simple web search for this matter (such as a search for "space between unit") yields plenty of results confirming this. Yet, the lack of space in writing is widespread. Many people and companies don't use the space, even though it's not right and even though they are wrong in doing so. Using a space is consistent with how we write in general, because wedon'ttypelikethis,whithoutspacesbetweenwhatwe'resaying.
You must include the space in your examples, so that they're free of spelling errors.
Correct example: 600 g (4 x 15 g).

Saying "Input a name (eg: Diet Coke)" WILL encourage and cause people to further make up names for the products, filling-in the data as made-up information rather than real, factual data.
Instead, it should say (using your format): Input main title (if any) exactly as given (eg: Chocolate Original).
That's short for "Input the product's main title (if any) exactly as written on the package."
Examples: Chocolate Original, Almond No Sugars, Walnuts.

@teolemon
Copy link
Member

@M123-dev
Copy link
Member

I agree with @teolemon the spacing and brand name problem is not the main concern of this issue, although interesting.

Concerning the feedback request:

  • I like the design
  • Multi language is looking good, but we would need to only show relevant languages

@g123k
Copy link
Collaborator Author

g123k commented Jul 29, 2024

  • We could reintroduce the common name edition (which has been widely cannibalized by the category system)

I was wondering why this field was removed in the Flutter app, any reason?
But if we add this field, will it be visible somewhere?

Multi language is looking good, but we would need to only show relevant languages

Thanks @M123-dev for your feedback, but could you elaborate on what you call "relevant languages"?

@M123-dev
Copy link
Member

M123-dev commented Oct 7, 2024

Sorry for my late reply @g123k, it's coming from an idea we had some long time back:

  • Allowing the user to have multiple favorite languages
    1. Living near a border
    1. I am on vacation so I also add the vacation language to my favorites for quick product addition in this language

I think it's particularly useful here, I won't be interested in the product data in Swedish, but maybe in Spanish since I have a basic knowledge of it

@teolemon teolemon removed the ✨ enhancement New feature or request label Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✏️ Editing - Basic info input ✏️ Editing - Text fields ✏️ Editing Many products are incomplete and don't have Nutri-Score, Eco-Score…so editing is important for users ✨ 2024 the big redesign
Projects
Status: 💬 To discuss and validate
Development

No branches or pull requests

4 participants