Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Easily dismissed) Grey screen in some cases for receipt scanning #5386

Closed
teolemon opened this issue Jun 16, 2024 · 3 comments
Closed

(Easily dismissed) Grey screen in some cases for receipt scanning #5386

teolemon opened this issue Jun 16, 2024 · 3 comments
Labels
🐛 bug Something isn't working Prices

Comments

@teolemon
Copy link
Member

What

  • (Easily dismissed) Grey screen in some cases for receipt scanning

Screenshot

image

@monsieurtanuki
Copy link
Contributor

@teolemon Technically it's not "Receipt Scanning", it's "Barcode Scanning" when adding a product to a receipt or price tags.

From my own experience, I assume it happens when going back to the app.
Probably related to camera being reactivated and all the tap dancing about it, especially given that we now have potentially 2 barcode readers at the same time - the "home" one and this "prices" one.

@g123k Are there plans to get rid of the current bottom bar mechanism? TBH it's getting a bit cryptical - the bottom bar is on some pages only, for an untold reason - and it causes a lot of problem about the camera being deactivated/reactivated (as opposed to "in the current page there is / isn't a barcode reader, therefore I do / don't need a camera").
I guess we could keep the bottom bar while not pretending to display 3 pages simultaneously, what do you think?

@g123k
Copy link
Collaborator

g123k commented Jun 16, 2024

@teolemon Technically it's not "Receipt Scanning", it's "Barcode Scanning" when adding a product to a receipt or price tags.

From my own experience, I assume it happens when going back to the app. Probably related to camera being reactivated and all the tap dancing about it, especially given that we now have potentially 2 barcode readers at the same time - the "home" one and this "prices" one.

@g123k Are there plans to get rid of the current bottom bar mechanism? TBH it's getting a bit cryptical - the bottom bar is on some pages only, for an untold reason - and it causes a lot of problem about the camera being deactivated/reactivated (as opposed to "in the current page there is / isn't a barcode reader, therefore I do / don't need a camera"). I guess we could keep the bottom bar while not pretending to display 3 pages simultaneously, what do you think?

In the POC, there's still the bottom bar, but I have implemented the camera with a different algorithm.
Currently, in the app, we use the default mode = autostart. It forces the camera to be opened and to prevent edge cases, we have several if to close it, if we are on a different screen.

In the POC, I do things differently, where I manage manually when I want the camera.
But changing things in the current version brings us to months ago (bugs & co).
If we have a plan B, I wouldn't be against.

@monsieurtanuki
Copy link
Contributor

@teolemon It's been a long time since I experienced that grey screen bug. Feel free to reopen if needed.

@github-project-automation github-project-automation bot moved this from 💬 To discuss and validate to 🎊 Done in 🤳🥫 The Open Food Facts mobile app (Android & iOS) Aug 30, 2024
@github-project-automation github-project-automation bot moved this from Backlog to Done in 💸 Open Prices Aug 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working Prices
Development

No branches or pull requests

3 participants