Do we still need device_preview?

[g123k]

Hi everyone,

I don't really like this dependency personally, but it's becoming a pain to develop with it:

• keyboard on the desktop is not working
• a11n tester on Android doesn't recognize any element

I know that I can disable it, but is-it really used?

[monsieurtanuki]

@g123k While you're here please consider

• removing useless package sensors_plus in chore: removed irrelevant dependency on package sensors_plus #5040
• removing dead code in refactor: removal of the useless/unused file cache manager #5087

Regarding device_preview I don't use it - I comment it.

[g123k]

@g123k While you're here please consider

• removing useless package sensors_plus in chore: removed irrelevant dependency on package sensors_plus #5040
• removing dead code in refactor: removal of the useless/unused file cache manager #5087

Regarding device_preview I don't use it - I comment it.

For sensors_plus, clearly YES, it's totally removable today. But I think, one way or another, I will bring it back.
So, I don't have a strong opinion.

For cache manager, I remember creating it, but I don't remember why.
So you can reopen (recreate?) a PR to remove it

[monsieurtanuki]

I've just reopened both PRs.
I have no problem with needed packages, so feel free to reintroduce sensors_plus when relevant, but for the moment we'd be better off without it (and I'll get less error messages in my emulator).

Regarding device_preview, I would recommend commenting it in both pubspec.yaml and main.dart: we very rarely need it but it will be ready after a couple of uncommentings.
Or let's get rid of it altogether, I don't really mind.

[g123k]

I've just reopened both PRs. I have no problem with needed packages, so feel free to reintroduce sensors_plus when relevant, but for the moment we'd be better off without it (and I'll get less error messages in my emulator).

Regarding device_preview, I would recommend commenting it in both pubspec.yaml and main.dart: we very rarely need it but it will be ready after a couple of uncommentings. Or let's get rid of it altogether, I don't really mind.

Oops didn't see your comment before my PR.
Actually, running the app in the desktop mode is more or less the same.

Instead of uncommenting, we can maybe create a script (I'm not really a fan of commenting)

[monsieurtanuki]

Removed in #5302.