Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent header in the editing sections #4925

Closed
teolemon opened this issue Dec 24, 2023 · 2 comments · Fixed by #4931
Closed

Inconsistent header in the editing sections #4925

teolemon opened this issue Dec 24, 2023 · 2 comments · Fixed by #4931
Labels
✏️ Editing Many products are incomplete and don't have Nutri-Score, Eco-Score…so editing is important for users good first issue Good for newcomers

Comments

@teolemon
Copy link
Member

teolemon commented Dec 24, 2023

What

Inconsistent header in the editing sections

edit basic details edit categories
Screenshot_20231224-103534.png Screenshot_20231224-103509.png
@monsieurtanuki
Copy link
Contributor

Basically there are 3 things to display for the title:

  • product name + brand
  • barcode
  • an optional specific page title like "Add basic details"

And the back button (currently a left arrow or a cross).

Which configuration should we apply to all product pages?

@monsieurtanuki monsieurtanuki added the good first issue Good for newcomers label Dec 27, 2023
@monsieurtanuki
Copy link
Contributor

Let's say the "edit basic details" is the best choice, to be copied to other "edit product" pages (except THE "edit product" page, that needs to keep the barcode):

  • app bar title is the specific topic (e.g. "Basic details" or "Categories")
  • app bar subtitle is the product name + brand
  • the back button is a left arrow (which means opening the page as "normal" page and not as full screen dialog)

@monsieurtanuki monsieurtanuki self-assigned this Dec 28, 2023
@monsieurtanuki monsieurtanuki removed their assignment Dec 29, 2023
@teolemon teolemon added the ✏️ Editing Many products are incomplete and don't have Nutri-Score, Eco-Score…so editing is important for users label Dec 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✏️ Editing Many products are incomplete and don't have Nutri-Score, Eco-Score…so editing is important for users good first issue Good for newcomers
Development

Successfully merging a pull request may close this issue.

2 participants