Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a complete list of localizedCountries #4921

Open
abdullah-khudher opened this issue Dec 24, 2023 · 6 comments
Open

Add a complete list of localizedCountries #4921

abdullah-khudher opened this issue Dec 24, 2023 · 6 comments
Labels
countries fixed ? This bug might already be fixed. If so, close it. 🤗 Onboarding We need to onboard users on how the app works, but also on content like Nutri-Score, Eco-Score…

Comments

@abdullah-khudher
Copy link
Contributor

What

  • I know this task was assigned to @g123k but i passed through it, so I added all Countries.

Screenshot

Screen Shot 2023-12-24 at 12 35 43 PM
@teolemon
Copy link
Member

Wondering, basically it's a fallback if we don't manage to get the countries taxonomy?
Or is that related to weird mappings like UK ?

@abdullah-khudher
Copy link
Contributor Author

@teolemon Yes, it's a fallback if we don't manage to get the countries taxonomy from iso_countries package

@teolemon teolemon added 🤗 Onboarding We need to onboard users on how the app works, but also on content like Nutri-Score, Eco-Score… countries labels Dec 29, 2023
@monsieurtanuki
Copy link
Contributor

@teolemon @abdullah-khudher For the record the iso_countries package we use supports only android and ios.
That means that the fallback (only translations in English) will always be used for the other platforms like Windows or Linux.

@M123-dev
Copy link
Member

M123-dev commented Jan 7, 2024

Something gala found a couple of days ago

IMG_2835

@monsieurtanuki
Copy link
Contributor

Back in the USSR? It's obviously my Beatles period after yesterday's Norwegian wood. I hope the next one is not "Help!" ;)

Beyond that, finding "Mexico", "Myanmar" and "Tanzania" first when you're looking for "uni" is a bit problematic.

We don't provide localizations anyway, they are provided by the os (android and ios only).

@M123-dev
Copy link
Member

M123-dev commented Jan 7, 2024

Back in the USSR? It's obviously my Beatles period after yesterday's Norwegian wood. I hope the next one is not "Help!" ;)

@teolemon also dropped Back in the USSR 😆

Beyond that, finding "Mexico", "Myanmar" and "Tanzania" first when you're looking for "uni" is a bit problematic.

yes ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
countries fixed ? This bug might already be fixed. If so, close it. 🤗 Onboarding We need to onboard users on how the app works, but also on content like Nutri-Score, Eco-Score…
Projects
Status: 💬 To discuss and validate
Development

No branches or pull requests

4 participants