Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional failure sources for background task #4883

Open
Tracked by #4881
teolemon opened this issue Dec 8, 2023 · 0 comments
Open
Tracked by #4881

Additional failure sources for background task #4883

teolemon opened this issue Dec 8, 2023 · 0 comments

Comments

@teolemon
Copy link
Member

teolemon commented Dec 8, 2023

The approach with if (storedUser.userId == currentUser.userId) … change password seems OK.
But it won't totally fix the issue, with this kind of flow:

User A : New background task
User A : new password + new login in the app
User B : login in the app

In that particular case, the background task won't use the latest password from User A.
Instead, I would "simply do": when a user logs in, iterate in all pending tasks and update the password if this is the relevant user.

Such behavior would allow notifying the user when we have some incorrect password error and quickly fix all issues

Originally posted by @g123k in #4869 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: 💬 To discuss and validate
Development

No branches or pull requests

1 participant