Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grey screen in production (Build 1241) from Oct 26 (ingredients) #4780

Open
teolemon opened this issue Nov 13, 2023 · 6 comments
Open

Grey screen in production (Build 1241) from Oct 26 (ingredients) #4780

teolemon opened this issue Nov 13, 2023 · 6 comments

Comments

@teolemon
Copy link
Member

teolemon commented Nov 13, 2023

What

  • Grey screen in production (Build 1241) from Oct 26 (ingredients)
  • Happened on new product scan.
  • Refresh doesn't fix it.
  • Reproducible on Valentin's device (build from Oct 26th)
  • Not reproducible on my device (build from Nov 1st), after a search by barcode.
  • Barcode below
@monsieurtanuki
Copy link
Contributor

Fixed by #4705 (4.11.0, 34f3364)

@g123k
Copy link
Collaborator

g123k commented Nov 14, 2023

It seems the issue is not fixed by the PR.
Version 1241 was released on the 26th of October VS the PR was merged on the 08th

@g123k g123k reopened this Nov 14, 2023
@monsieurtanuki
Copy link
Contributor

@g123k You may be right as I don't understand 100% of the release process, but on the OP screenshot the version is 4.9.2 and the PR was included in 4.11.0.
In addition to that, I tested with or without the PR, and I got a grey screen without it (actually a red one with a null pointer exception as it was in debug mode).
Of course there could be other reasons for a grey screen, but a null pointer exception for a null brand looks very tempting.
Feel free to close this issue again if my arguments make sense.

@monsieurtanuki monsieurtanuki removed their assignment Nov 14, 2023
@g123k
Copy link
Collaborator

g123k commented Nov 14, 2023

As I'm not 100% sure, @teolemon : could you generate a new internal build and ensure it's based on the 4.11.x, please?

@teolemon
Copy link
Member Author

I've pushed a build, but based on the dates on what was previously in production, and the commits I have reviewed, I don't believe we have a fix @monsieurtanuki @g123k

@monsieurtanuki
Copy link
Contributor

@teolemon @g123k Therefore the github details are perhaps misleading:
Capture d’écran 2023-11-15 à 10 15 59

@teolemon teolemon removed the 🐛 bug Something isn't working label Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

3 participants