Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

For you: allow selecting personal values from knowledge panels #4628

Closed
g123k opened this issue Sep 7, 2023 · 3 comments · Fixed by #4778
Closed

For you: allow selecting personal values from knowledge panels #4628

g123k opened this issue Sep 7, 2023 · 3 comments · Fixed by #4778

Comments

@g123k
Copy link
Collaborator

g123k commented Sep 7, 2023

Hi everyone,

As part of the redesign and the Personal track, we plan to add a major feature to the product page: a "for me" section.

In this section, by default, we will show the results from the food preferences (out of scope here).
However, the second kind of content in this "For me" section is the ability to select personal values from the knowledge panels.

Let's take a few examples:

  • I want to get the NOVA score without scrolling in the Health section
  • I want to know how much salt the product contains in the Nutrition section

To implement this feature, knowledge panels have specific IDs, and we need to store the ones the user wants.
But also have in mind that a knowledge panel can recursively contains others.

The UI is not yet ready for the redesign, but we can still implement a few things:

  • Allow to select one or more knowledge panels (titles are excluded, we only want values)
  • Allow to reorder the selected knowledge panels
@monsieurtanuki
Copy link
Contributor

We should definitely be able to reorder the KP, like "I want to know what I want to know, not everything there's to know about this product".

A bonus would be to be able to share your settings with a friend, like "with this settings you'll be able to select good food for you".

A simple UI/UX solution would be to

  • trigger a "reorder KP" mode (long click? specific new button?)
  • that would open a specific page - same data but unclickable and obviously movable, like with ReorderableListView

@monsieurtanuki
Copy link
Contributor

My first tests are very interesting.
I've implemented a reorderable list, accessible from the product page, that lets me reorder the knowledge panels. So that they match my needs, not what is decided for everybody in the default knowledge panel order.
In one page I can see 6 KPs, and only 2 of them are both on the default order and on my own order:

the default order the order I would want
Screenshot_2023-09-17-17-20-44 Screenshot_2023-09-17-17-23-33

A suggestion - a "reorder" button:
Screenshot_2023-09-17-17-09-25

I'm about to PR a needed refactoring. Not the final implementation.

@monsieurtanuki
Copy link
Contributor

Of course the reordering of KP could be reused in the "Compare 3 products" feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment