Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the edit mode of the mobile app compatible with OxF #4540

Open
4 of 9 tasks
Tracked by #4543 ...
teolemon opened this issue Aug 15, 2023 · 2 comments
Open
4 of 9 tasks
Tracked by #4543 ...

Make the edit mode of the mobile app compatible with OxF #4540

teolemon opened this issue Aug 15, 2023 · 2 comments
Labels
✏️ Editing Many products are incomplete and don't have Nutri-Score, Eco-Score…so editing is important for users 🎨 Mockup required 🧴 Open Beauty Facts Please see this proposal: https://github.com/openfoodfacts/smooth-app/discussions/1378 🐾 Open Pet Food Facts 📸 Open Products Facts OxF

Comments

@teolemon
Copy link
Member

teolemon commented Aug 15, 2023

Problem

  • If we ever want to have an app able to handle any kind of product, the edit mode has to behave differently

Make the edit mode compatible with Open Beauty Facts, Open Pet Food Facts and Open Products Facts

  1. ✏️ Editing 🧴 Open Beauty Facts
  2. folksonomy engine ✏️ Editing 📸 Open Products Facts
  3. 🐾 Open Pet Food Facts
  4. 2 of 8
    Epic folksonomy engine help wanted 🎨 Mockups available 🎯 P1 📸 Open Products Facts
  5. 📸 Open Products Facts 🧴 Open Beauty Facts
    monsieurtanuki
  6. ✏️ Editing 🐾 Open Pet Food Facts 📸 Open Products Facts 🧴 Open Beauty Facts
    monsieurtanuki

Part of

@teolemon teolemon added 🧴 Open Beauty Facts Please see this proposal: https://github.com/openfoodfacts/smooth-app/discussions/1378 ✏️ Editing Many products are incomplete and don't have Nutri-Score, Eco-Score…so editing is important for users 📸 Open Products Facts 🐾 Open Pet Food Facts OxF labels Aug 15, 2023
@monsieurtanuki
Copy link
Contributor

If we ever want to have an app able to handle any kind of product, the edit mode has to behave differently

@teolemon For the moment we only have one kind of Product.
Do you expect all kinds of products to fit into that unique class, or should we create classes like BeautyProduct, PetFoodProduct and GenericProduct?

@teolemon
Copy link
Member Author

teolemon commented Sep 6, 2024

@monsieurtanuki yes, @stephanegigandet is working on that at the moment.
The data structure will be mostly the same, and we will only remove fields (eg nutrition).
Fields additions are likely to happen in the Folksonomy Engine.
I have clarified the issue to mention that we can honor a product type for all products, based on the root URL in DEV mode, and that as soon as we have a universal scan api, we can honor the product_type from the server

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✏️ Editing Many products are incomplete and don't have Nutri-Score, Eco-Score…so editing is important for users 🎨 Mockup required 🧴 Open Beauty Facts Please see this proposal: https://github.com/openfoodfacts/smooth-app/discussions/1378 🐾 Open Pet Food Facts 📸 Open Products Facts OxF
Projects
Status: Todo
Status: To do
Status: To do
Status: 💬 To discuss and validate
Status: To Discuss & Validate
Development

No branches or pull requests

2 participants