Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Product -> Add to a list -> The product view is not refreshed #4465

Closed
Tracked by #4463
g123k opened this issue Aug 7, 2023 · 0 comments · Fixed by #4486
Closed
Tracked by #4463

Product -> Add to a list -> The product view is not refreshed #4465

g123k opened this issue Aug 7, 2023 · 0 comments · Fixed by #4486
Assignees
@g123k
Labels
🐛 bug Something isn't working 🥫 Product page User lists
Milestone
Version 4.9 (earl...

Comments

@g123k
Copy link
Collaborator

g123k commented Aug 7, 2023 •
edited by teolemon
Loading

Hi everyone,

I've discovered, that when we are on a product, we can add/remove this product from a list. However, when we do this action, nothing happens visually speaking.

Here is a video of the issue: https://github.com/openfoodfacts/smooth-app/assets/246838/83a5efff-f846-4302-a10d-ed4e33eedff8

The error seems to be that when we add/remove, a setState is missing somewhere.

Part of
@g123k g123k mentioned this issue Aug 7, 2023
Closed
@g123k g123k self-assigned this Aug 8, 2023
@g123k g123k linked a pull request Aug 8, 2023 that will close this issue
fix: On the product page: ensure to refresh the screen if the product is added/removed from a list #4486
Merged
@teolemon teolemon added this to the Version 4.9 (early August) milestone Aug 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@g123k g123k

Labels
🐛 bug Something isn't working 🥫 Product page User lists
Projects
🤳🥫 The Open Food Facts mobile app (Android & iOS)
Archived in project
Milestone
Version 4.9 (early August)
2 participants
@g123k @teolemon