Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to barcode scanner when clicking on empty history screen or empty lists #1314

Closed
M123-dev opened this issue Mar 23, 2022 · 4 comments · Fixed by #2347
Closed

Switch to barcode scanner when clicking on empty history screen or empty lists #1314

M123-dev opened this issue Mar 23, 2022 · 4 comments · Fixed by #2347
Assignees
@cli1005
Labels
history P2
Milestone
V1.1

Comments

@M123-dev
Copy link
Member

#1126 (comment) @monsieurtanuki

Just a remark: it's very tempting, when on the empty history page, to click on the big central icon to start scanning. But nothing happens.

Maybe blocked on: #1313
@M123-dev M123-dev changed the title Switch to barcode scanenr when clicking on empty history screen Switch to barcode scanner when clicking on empty history screen Mar 23, 2022
@teolemon teolemon added good first issue Good for newcomers history labels Mar 24, 2022
@M123-dev M123-dev removed the good first issue Good for newcomers label Mar 24, 2022
@bhattabhi013
Copy link
Contributor

bhattabhi013 commented Mar 26, 2022 •
edited
Loading

Hi @M123-dev,
Can I work on this?

@M123-dev
Copy link
Member Author

Sure @bhattabhi013

@bhattabhi013 bhattabhi013 mentioned this issue Mar 28, 2022
Closed
@teolemon teolemon linked a pull request Mar 28, 2022 that will close this issue
fix: Switch to barcode scanner when clicking on the empty history screen #1363
Closed
@teolemon teolemon added this to the V 1 milestone Mar 31, 2022
@M123-dev M123-dev added P2 and removed 🎯 P1 labels Apr 30, 2022
@VaiTon
Copy link
Member

VaiTon commented Jun 5, 2022

@bhattabhi013 any news on this one?

@bhattabhi013
Copy link
Contributor

Hi @VaiTon,
I wasn't able to fix this due to some time issues. I'm unassigning myself so that someone else can work on it.

@bhattabhi013 bhattabhi013 removed their assignment Jun 8, 2022
@teolemon teolemon modified the milestones: V1, V1.1 Jun 18, 2022
@teolemon teolemon changed the title Switch to barcode scanner when clicking on empty history screen Switch to barcode scanner when clicking on empty history screen or empty lists Jun 20, 2022
cli1005 added a commit to cli1005/smooth-app that referenced this issue Jun 21, 2022
@cli1005
fix: openfoodfacts#1314 switch to scanner from empty list
a366e9b
cli1005 added a commit to cli1005/smooth-app that referenced this issue Jun 21, 2022
@cli1005
fix: openfoodfacts#1314 switch to scanner
03df43d 
even it is not first route of current tab
@cli1005 cli1005 mentioned this issue Jun 21, 2022
Merged
@cli1005 cli1005 moved this from In Progress to Pull Requests in 🤳🥫 The Open Food Facts mobile app (Android & iOS) Jun 21, 2022
teolemon pushed a commit that referenced this issue Jun 23, 2022
@cli1005
fix: #1314 switch to scanner from empty list (#2347)
2790dfb 
* fix: #1314 switch to scanner from empty list

* fix: #1314 switch to scanner
even it is not first route of current tab
Repository owner moved this from Pull Requests to Done in 🤳🥫 The Open Food Facts mobile app (Android & iOS) Jun 23, 2022
@github-actions github-actions bot mentioned this issue Sep 6, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cli1005 cli1005

Labels
history P2
Projects
🤳🥫 The Open Food Facts mobile app (Android & iOS)
Archived in project
Milestone
V1.1
5 participants
@teolemon @VaiTon @M123-dev @bhattabhi013 @cli1005