Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor gen_top_tags_per_countries #8715

Open
Tracked by #5527
alexgarel opened this issue Jul 21, 2023 · 2 comments
Open
Tracked by #5527

Refactor gen_top_tags_per_countries #8715

alexgarel opened this issue Jul 21, 2023 · 2 comments
Assignees
@stephanegigandet
Labels
🎯 P1 🚅 Performance ✅ Task

Comments

@alexgarel
Copy link
Member

alexgarel commented Jul 21, 2023 •
edited by teolemon
Loading

What

  • I 'm not sure of what gen_top_tags_per_country.pl is doing beyond https://fr.openfoodfacts.org/produits
  • But this script is dragging the whole mongodb database every hours !
  • In those time of limited resources, if we could avoid that, it would be great !

Part of
@alexgarel alexgarel added the task label Jul 21, 2023
@alexgarel
Copy link
Member Author

Consider:

  • running it every day only
  • using JSONL instead of mongodb (we would have a problem though as it is sorting entries right now, but this might be avoidable at the cost of loosing a small feature)
  • using a tool better adapted for the job (it seems like it would better fit in a SQL world)
  • keeping only needed functionality

@stephanegigandet
Copy link
Contributor

running it once a day is fine

@alexgarel alexgarel mentioned this issue Jul 25, 2023
Merged
@teolemon teolemon mentioned this issue Oct 2, 2023
Open
@teolemon teolemon added ✅ Task and removed task labels Nov 10, 2023
@teolemon teolemon moved this to To discuss and validate in 🍊 Open Food Facts Server issues Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stephanegigandet stephanegigandet

Labels
🎯 P1 🚅 Performance ✅ Task
Projects
🍊 Open Food Facts Server issues
Status: To discuss and validate
🎯 Very high impact issues
Status: To do
Milestone
No milestone
Development

No branches or pull requests
3 participants
@alexgarel @teolemon @stephanegigandet