Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove broken entries due to broken f-droid release #7648

Closed
natrius opened this issue Nov 3, 2022 · 7 comments
Closed

Remove broken entries due to broken f-droid release #7648

natrius opened this issue Nov 3, 2022 · 7 comments
Labels
🤳🥫 blocking mobile apps This issues are blocking a feature on the Open Food Facts mobile apps 🐛 bug This is a bug, not a feature request. 🧽 Data quality https://wiki.openfoodfacts.org/Quality ✏️ Editing

Comments

@natrius
Copy link

natrius commented Nov 3, 2022

Describe the bug

The current f-droid release (3.6.8) causes broken entries in the database. As far as i'm aware such a broken entry leads to desinterest when stumbling upon those.
In my opinion, these entries all should be deleted. Sorted by my country on page 95 (random choice)

image

That are entries cause by at least 3.6.8, i was able to reproduce it. I don't know if the apk from the website is causing the same problem but its even older, 3.6.6 (580?) if i recall correctly.

The most current 'old' one on F-Droid should be 3.8.1 (582) according to github.

To Reproduce

Expected behavior

A entry in the database with alle the info and pictures.

Screenshots

No response

Additional context

I raised the issue here openfoodfacts/openfoodfacts-androidapp#4868 already with no answer. I also tried the to download the new smooth app, but the apk is not available due to openfoodfacts/smooth-app#2771 (i commented there as well).

Lastly i kindly got the apk (734) from pierres (thanks again!) in the matrix-channel, still have to try that out. Pierre also mentioned to publicate a new f-droid version with a fixed mikit flavor -> because of that 3.8.1 did not got released on f-droid.

So

  • fix f-droid release
  • delete wrong database-entries

Number of products impacted

Since 29.09.2022 - looking at a monthly 35 items that would make 630 items that should frankly be deleted - just in my country (Austria) alone. Its mentioned in that the error was resolved, but the app was never updated.

Right now on World i'm counting on page 1 about 8, page 2 about 4, page 3 about 7, page 4 about 10. Lets take middle with 7 per page. 26489 pages would make about 185423 entries, probably less because i'm sure the problem is not there from the beginning. On the other hand, there are pages with a lot of these.

@natrius natrius added the 🐛 bug This is a bug, not a feature request. label Nov 3, 2022
@teolemon teolemon added ✏️ Editing 🧽 Data quality https://wiki.openfoodfacts.org/Quality labels Nov 3, 2022
@teolemon
Copy link
Member

teolemon commented Nov 3, 2022

cc @VaiTon @stephanegigandet any opinions on this ? We haven't changed anything to image upload, so I'm not sure what could be going on .

@teolemon teolemon added the 🤳🥫 blocking mobile apps This issues are blocking a feature on the Open Food Facts mobile apps label Nov 3, 2022
@natrius
Copy link
Author

natrius commented Nov 3, 2022

No, its just an old (at least one year?) issue thats solved already. openfoodfacts/openfoodfacts-androidapp#3982
The problem is:

  • Old version in f-droid
  • Old version (APK) on the Website

And at least the version in the F-Droid-Store leads to the error. And its not possible to get the most recent apk anywhere. But still, in my opinion the wrong entries do more harm than help and should get deleted.

@VaiTon
Copy link
Member

VaiTon commented Nov 6, 2022

Hey @natrius! If we deploy the new flutter app to the F-Droid store replacing the current listing it should not be a problem anymore. Let's wait for openfoodfacts/smooth-app#2771

@natrius
Copy link
Author

natrius commented Nov 6, 2022

Yeah, thats fine, but in this issue i talk about the old, already existing database entries That do more harm Than good in my opinion.

@VaiTon
Copy link
Member

VaiTon commented Nov 6, 2022

So, TODOs:

@natrius
Copy link
Author

natrius commented Dec 18, 2022

The old app got updated and works now - see openfoodfacts/openfoodfacts-androidapp#4868 I think it would now be proper to remove the faulty entries as its possible to upload correct ones. The app from F-Droid works, the apk on the website is still old, but i will create a separate issue for that :)

EDIT: Actually, there is an issue about it already - #7697

@teolemon
Copy link
Member

I'm going to close this one, the products got cleaned up @natrius

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🤳🥫 blocking mobile apps This issues are blocking a feature on the Open Food Facts mobile apps 🐛 bug This is a bug, not a feature request. 🧽 Data quality https://wiki.openfoodfacts.org/Quality ✏️ Editing
Projects
Development

No branches or pull requests

3 participants