Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Water should be ignored when computing percent of fruit #7222

Closed
alexgarel opened this issue Aug 18, 2022 · 6 comments
Closed

Water should be ignored when computing percent of fruit #7222

alexgarel opened this issue Aug 18, 2022 · 6 comments
Labels
🐛 bug This is a bug, not a feature request. fruits vegetables nuts estimate 🥗🔍 Ingredients analysis https://wiki.openfoodfacts.org/Ingredients_Extraction_and_Analysis 🚦 Nutri-Score ⏰ Stale This issue hasn't seen activity in a while. You can try documenting more to unblock it.

Comments

@alexgarel
Copy link
Member

alexgarel commented Aug 18, 2022

What

If we have a product with this composition (in french): "prune, eau", the estimated percentage of fruit is min:50% which affects the nutriscore, for Fruits‚ vegetables‚ nuts and rapeseed‚ walnut and olive oils (estimate from ingredients list analysis) is then 50%.
see: https://world.openfoodfacts.org/product/3760324841617/pruneaux-d-agen-entiers-tres-gros-la-fourche?rev=16

Shouldn't the water be estimated as part of this ? Thus making estimated percentage 100% ?

To Reproduce

see: https://world.openfoodfacts.org/product/3760324841617/pruneaux-d-agen-entiers-tres-gros-la-fourche?rev=16

Expected behavior

Fruits‚ vegetables‚ nuts and rapeseed‚ walnut and olive oils (estimate from ingredients list analysis) should be 100%

Part of

@alexgarel alexgarel added 🐛 bug This is a bug, not a feature request. 🥗🔍 Ingredients analysis https://wiki.openfoodfacts.org/Ingredients_Extraction_and_Analysis labels Aug 18, 2022
@alexgarel
Copy link
Member Author

cc @stephanegigandet

@teolemon teolemon added the 🚦Nutri-Score https://world.openfoodfacts.org/nutriscore label Aug 18, 2022
@stephanegigandet
Copy link
Contributor

Water should not be ignored, the % of fruits is the % of fruits. e.g. a fruit nectar with 25% fruits, sugar 10% and 65% water should have 25% of fruits.

@stephanegigandet
Copy link
Contributor

For https://fr.openfoodfacts.org/produit/3760324841600/pruneaux-d-agen-la-fourche , we should add "Prunes d'Ente" in the ingredients taxonomy though.

@github-actions
Copy link
Contributor

This issue is stale because it has been open 90 days with no activity.

@github-actions github-actions bot added ⏰ Stale This issue hasn't seen activity in a while. You can try documenting more to unblock it. and removed ⏰ Stale This issue hasn't seen activity in a while. You can try documenting more to unblock it. labels Nov 17, 2022
Copy link
Contributor

github-actions bot commented Jan 3, 2024

This issue has been open 90 days with no activity. Can you give it a little love by linking it to a parent issue, adding relevant labels and projets, creating a mockup if applicable, adding code pointers from https://github.com/openfoodfacts/openfoodfacts-server/blob/main/.github/labeler.yml, giving it a priority, editing the original issue to have a more comprehensive description… Thank you very much for your contribution to 🍊 Open Food Facts

@github-actions github-actions bot added the ⏰ Stale This issue hasn't seen activity in a while. You can try documenting more to unblock it. label Jan 3, 2024
@stephanegigandet
Copy link
Contributor

Closing as the % of fruits is working as specified (not ignoring water).

@teolemon teolemon added 🚦 Nutri-Score and removed 🚦Nutri-Score https://world.openfoodfacts.org/nutriscore labels May 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug This is a bug, not a feature request. fruits vegetables nuts estimate 🥗🔍 Ingredients analysis https://wiki.openfoodfacts.org/Ingredients_Extraction_and_Analysis 🚦 Nutri-Score ⏰ Stale This issue hasn't seen activity in a while. You can try documenting more to unblock it.
Projects
Status: Done
Development

No branches or pull requests

3 participants