Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add handling for "amount of product for each Xg/mL of product" #3642

Closed
Tracked by #9096
AcuarioCat opened this issue Jun 16, 2020 · 10 comments
Closed
Tracked by #9096

Add handling for "amount of product for each Xg/mL of product" #3642

AcuarioCat opened this issue Jun 16, 2020 · 10 comments
Assignees
Labels
🐛 bug This is a bug, not a feature request. 🥗🔍 Ingredients analysis https://wiki.openfoodfacts.org/Ingredients_Extraction_and_Analysis 🥗 Ingredients

Comments

@AcuarioCat
Copy link
Contributor

AcuarioCat commented Jun 16, 2020

What

  • Commonly found in sauces and purees but also in meat products, an example:
    • Tomate* (160g de tomate por cada 100g de producto final), code 8425205013532
  • This structure is currently unhandled and results in unknown.

Another example:
Elabora con 59 g de fruta por 100 g
Code 8410095507001

Part of

@AcuarioCat AcuarioCat added 🐛 bug This is a bug, not a feature request. 🥗 Ingredients 🥗🔍 Ingredients analysis https://wiki.openfoodfacts.org/Ingredients_Extraction_and_Analysis labels Jun 16, 2020
@aleene
Copy link
Contributor

aleene commented Jun 16, 2020

This is probably an issue in any language.

@Ban3
Copy link
Contributor

Ban3 commented Jun 16, 2020

Elabora con 59 g de fruta por 100 g

I believe the French equivalents are ignored by the parser:

https://github.com/openfoodfacts/openfoodfacts-server/blob/master/lib/ProductOpener/Ingredients.pm#L1190-L1203

@aleene
Copy link
Contributor

aleene commented Jun 16, 2020

Dutch: Bereid met 45 g vruchten per 100 g

@aleene
Copy link
Contributor

aleene commented Jun 16, 2020

Préparée avec 61 g de fruits pour 100g

Teneur totale en sucres: 61 g pour 100 g.

@AcuarioCat
Copy link
Contributor Author

English: 148g per 100g

@Ban3
Copy link
Contributor

Ban3 commented Jun 18, 2020

Danish: Fremstillet af x g frugt per 100g
Swedish: Fruktråvara x g per 100g

@github-actions github-actions bot added the ⏰ Stale This issue hasn't seen activity in a while. You can try documenting more to unblock it. label Jan 15, 2021
@teolemon teolemon removed the ⏰ Stale This issue hasn't seen activity in a while. You can try documenting more to unblock it. label Jul 19, 2021
@teolemon teolemon changed the title Add handling for amount of product for each X of product Add handling for "amount of product for each Xg/mL of product" Oct 12, 2022
@benbenben2
Copy link
Collaborator

HR
Proizvedeno od 80g voća na 100g gotovog proizvoda
https://hr.openfoodfacts.org/product/3859888295261/smokva-doma%C4%87a-d%C5%BEem-marina

What could we do with that:

  • Ignore/remove that kind of text?
  • Could it be used for something?

@teolemon, @stephanegigandet

@stephanegigandet
Copy link
Contributor

@benbenben2 in fact we now have a feature to parse those mentions from ingredients lists, in Ingredients.pm

=head2 parse_specific_ingredients_from_text ( product_ref, $text, $percent_or_quantity_regexp )

Lists of ingredients sometime include extra mentions for specific ingredients
at the end of the ingredients list. e.g. "Prepared with 50g of fruits for 100g of finished product".

This function extracts those mentions and adds them to the specific_ingredients structure.

This function is also used to parse the origins of ingredients field.


We could try to support all the languages / phrases that have been collected in this issue.

@benbenben2
Copy link
Collaborator

@stephanegigandet should we close this issue?

@stephanegigandet
Copy link
Contributor

@stephanegigandet should we close this issue?

Sure, thank you very much for all your work on this @benbenben2 !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug This is a bug, not a feature request. 🥗🔍 Ingredients analysis https://wiki.openfoodfacts.org/Ingredients_Extraction_and_Analysis 🥗 Ingredients
Projects
Development

Successfully merging a pull request may close this issue.

6 participants