Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add or separate states of ingredients in taxonomy #3589

Open
Tracked by #9096
AcuarioCat opened this issue Jun 11, 2020 · 3 comments
Open
Tracked by #9096

Add or separate states of ingredients in taxonomy #3589

AcuarioCat opened this issue Jun 11, 2020 · 3 comments
Labels
🥗🔍 Ingredients analysis https://wiki.openfoodfacts.org/Ingredients_Extraction_and_Analysis processing ⏰ Stale This issue hasn't seen activity in a while. You can try documenting more to unblock it.

Comments

@AcuarioCat
Copy link
Contributor

AcuarioCat commented Jun 11, 2020

Ingredients are processed through several of the taxonomies but in each taxonomy only once.
In some cases this means the state of the ingredient or certain attributes of products have to be included in the ingredients taxonomy as well as the prime ingredient.

For example, Flavouring. As this is only included in ingredients it has to be repeated for every possible flavor, i.e. elderberry flavouring won't process as it's not in the ingredients however orange flavouring will as it exists in ingredients. Both elderberry and flavouring are in ingredients but as there is only a single pass and the two keywords are in ingredients it does not get processed.
There are many more examples of this occurring.

Suggestion: Either add a new taxonomy for attributes or states that includes keywords such as flavouring, flour etc. or add these states to an existing taxonomy such as ingredients_processing.

Part of

@AcuarioCat AcuarioCat added the ✨ Feature Features or enhancements to Open Food Facts server label Jun 11, 2020
@aleene
Copy link
Contributor

aleene commented Jun 11, 2020

I sort of agree. I would like to extend the processing taxonomy to an adjectives taxonomy, this could include flour and juice (I did not start working in that one yet).

The flavour one is more difficult, as many flavours do not have a relation with their taste. For example strawberry flavour is not made from strawberries, even if it says natural. So the ingredient flavour must kept separate, as it is really ingredient (made from fungi and yeasts).

@stephanegigandet
Copy link
Contributor

I agree that we could consider flour and juice to be processing.

Flavors are much more complex. It will probably require a special system and parsing.

Copy link
Contributor

This issue has been open 90 days with no activity. Can you give it a little love by linking it to a parent issue, adding relevant labels and projets, creating a mockup if applicable, adding code pointers from https://github.com/openfoodfacts/openfoodfacts-server/blob/main/.github/labeler.yml, giving it a priority, editing the original issue to have a more comprehensive description… Thank you very much for your contribution to 🍊 Open Food Facts

@github-actions github-actions bot added the ⏰ Stale This issue hasn't seen activity in a while. You can try documenting more to unblock it. label Feb 25, 2024
@teolemon teolemon moved this to To discuss and validate in 🍊 Open Food Facts Server issues Apr 23, 2024
@teolemon teolemon removed the ✨ Feature Features or enhancements to Open Food Facts server label Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🥗🔍 Ingredients analysis https://wiki.openfoodfacts.org/Ingredients_Extraction_and_Analysis processing ⏰ Stale This issue hasn't seen activity in a while. You can try documenting more to unblock it.
Projects
Status: To do
Status: To discuss and validate
Development

No branches or pull requests

4 participants