Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore explanations at end of list of ingredients like ". *Organic Ingredients" #3030

Closed
Tracked by #9096
bredowmax opened this issue Mar 13, 2020 · 7 comments · Fixed by #8942
Closed
Tracked by #9096

Ignore explanations at end of list of ingredients like ". *Organic Ingredients" #3030

bredowmax opened this issue Mar 13, 2020 · 7 comments · Fixed by #8942
Assignees
@benbenben2
Labels
🐛 bug This is a bug, not a feature request. 🧽 Data quality https://wiki.openfoodfacts.org/Quality 🥗🔍 Ingredients analysis https://wiki.openfoodfacts.org/Ingredients_Extraction_and_Analysis organic products

Comments

@bredowmax
Copy link

bredowmax commented Mar 13, 2020 •
edited by teolemon
Loading

What

OFF seems not to handle explanations at the end of lists of ingredients like * Organic Ingredients very well. I've seen examples of these quite often here in the US

Steps to Reproduce

https://world.openfoodfacts.org/product/0850003875088/jalapeno-vegan-cheddar-hippeas
https://world.openfoodfacts.org/product/0099482485375/fried-rice-style-riced-cauliflower-whole-foods-market

Expected behavior

OFF should ignore a string like . * and whatever follows after it. It's mostly just explanations

Discussion

https://openfoodfacts.slack.com/archives/C06A7LENM/p1584094524048900

Part of
@bredowmax bredowmax added the 🐛 bug This is a bug, not a feature request. label Mar 13, 2020
@stephanegigandet
Copy link
Contributor

For the first product, we actually handle it well. We don't ignore the "* Organic Ingredients" --> we actually tag corresponding ingredients as organic.

image

The second one is not handled well.

What we need to do is to identify the most common "* something" to see which ones are actually useful to understand (e.g. when it specifies that an ingredient is organic, fair trade etc.), with the most common wordings. (e.g. for French we support a ton of variations of "* : ingredients that have been produced in an organic way")

@bredowmax
Copy link
Author

May contain 2% or less of
https://world.openfoodfacts.org/product/0603028799132/gluten-free-fusilli

@bredowmax
Copy link
Author

https://world.openfoodfacts.org/product/0856500004013/organic-hummus-hope
https://world.openfoodfacts.org/product/0856500004037/organic-hummus-thai-coconut-curry-hope

@bredowmax
Copy link
Author

Contains:
I've often added this accidentally to ingredients. Not sure if this is parsed correctly already
https://world.openfoodfacts.org/product/0029737700144/potato-cheese-severino

@bredowmax
Copy link
Author

bredowmax commented Mar 13, 2020 •
edited
Loading

Another edge case: When ingredients are separated into 2 different groups:

@bredowmax
Copy link
Author

*SPICES AND OR VEGETABLE POWDER as last ingredient when that flavor
https://world.openfoodfacts.org/product/2252559300126/egg-vermicelli

@bredowmax bredowmax mentioned this issue Mar 14, 2020
Closed
@VaiTon VaiTon added the 🥗🔍 Ingredients analysis https://wiki.openfoodfacts.org/Ingredients_Extraction_and_Analysis label Mar 15, 2020
@VaiTon VaiTon mentioned this issue Mar 15, 2020
Open
@github-actions
Copy link
Contributor

Stale issue message

@github-actions github-actions bot closed this as completed Jul 7, 2020
@teolemon teolemon mentioned this issue Oct 12, 2022
Open
@CharlesNepote CharlesNepote added the 🧽 Data quality https://wiki.openfoodfacts.org/Quality label Aug 21, 2023
@benbenben2 benbenben2 mentioned this issue Sep 3, 2023
Merged
@benbenben2 benbenben2 self-assigned this Sep 3, 2023
@benbenben2 benbenben2 moved this from To do to In progress in 🧽 Ensuring Data Quality Sep 3, 2023
@benbenben2 benbenben2 moved this from In progress to Needs review in 🧽 Ensuring Data Quality Sep 3, 2023
@github-project-automation github-project-automation bot moved this from Needs review to Done in 🧽 Ensuring Data Quality Sep 8, 2023
@teolemon teolemon mentioned this issue Oct 2, 2023
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@benbenben2 benbenben2

Labels
🐛 bug This is a bug, not a feature request. 🧽 Data quality https://wiki.openfoodfacts.org/Quality 🥗🔍 Ingredients analysis https://wiki.openfoodfacts.org/Ingredients_Extraction_and_Analysis organic products
Projects
🍊 Open Food Facts Server issues
Archived in project
🧽 Ensuring Data Quality
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: improve ingredients extraction openfoodfacts/openfoodfacts-server
6 participants
@CharlesNepote @teolemon @stephanegigandet @VaiTon @bredowmax @benbenben2