Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add app name and version to the WRITE API fields #1206

Open
Tracked by #5523
, #8919
...
aleene opened this issue May 5, 2018 · 3 comments
Open
Tracked by #5523
, #8919
...

Add app name and version to the WRITE API fields #1206

aleene opened this issue May 5, 2018 · 3 comments
Labels
🔐 API auth The API requires auth in order to perform editing.There is a common mechanism & a Robotoff mechanism API WRITE WRITE API to allow sending product info and image 🤳🥫 blocking mobile apps This issues are blocking a feature on the Open Food Facts mobile apps 🤳🥫 mobile apps

Comments

@aleene
Copy link
Contributor

aleene commented May 5, 2018 •
edited by teolemon
Loading

What

-Add fields to the write api for the app client name and the app client version number. This should identify which app is submitting the data.

  • Consequently any app that misuses the api, can be blocked and the data can be repaired.

Part of
@hangy
Copy link
Member

hangy commented May 7, 2018

I'd prefer a token based approach like OIDC #1204 where the app is based off the auth token that was issued for a specific app. That would make it more difficult to fake being another app (which might be used to get a competing app banned).

@teolemon teolemon added the API WRITE WRITE API to allow sending product info and image label May 19, 2018
@aleene
Copy link
Contributor Author

aleene commented May 19, 2018

Does this also allow the user to sign in?

@hangy
Copy link
Member

hangy commented Dec 17, 2018

Does this also allow the user to sign in?

Sorry for the late reply! No, it would not. And I think my previous idea of integrating that with OIDC is not good. We could investigate using API keys from tools like Gravitee to identify API consumers. Adding additional edit metadata such as the client's version is probably a good idea anyways!

@teolemon teolemon mentioned this issue Aug 21, 2021
Open
@teolemon teolemon added the 🔐 API auth The API requires auth in order to perform editing.There is a common mechanism & a Robotoff mechanism label Apr 29, 2022
@teolemon teolemon added 🤳🥫 blocking mobile apps This issues are blocking a feature on the Open Food Facts mobile apps 🤳🥫 mobile apps labels Jun 14, 2023
@teolemon teolemon mentioned this issue Aug 28, 2023
Open
@teolemon teolemon changed the title Add app name and version to write api fields Add app name and version to the WRITE API fields Oct 31, 2023
@teolemon teolemon moved this to To discuss and validate in 🍊 Open Food Facts Server issues Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🔐 API auth The API requires auth in order to perform editing.There is a common mechanism & a Robotoff mechanism API WRITE WRITE API to allow sending product info and image 🤳🥫 blocking mobile apps This issues are blocking a feature on the Open Food Facts mobile apps 🤳🥫 mobile apps
Projects
🍊 Open Food Facts Server issues
Status: To discuss and validate
Milestone
No milestone
Development

No branches or pull requests
3 participants
@hangy @aleene @teolemon