Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenAPI definition doesn't reflect correctly some packaging fields returned by API #10989

Open
void0x23 opened this issue Nov 7, 2024 · 1 comment
Labels
📚 OpenAPI 📦 Packaging https://wiki.openfoodfacts.org/Category:Recycling

Comments

@void0x23
Copy link

void0x23 commented Nov 7, 2024

This issue is related to a coherence problem i've found in the openapi specification, in particular the packaging section, where we can see
that the elements are described with 2 fields, id and lc_name.

Image

but they seems to be returned as a single string

Image

and this create problems during the automatic generation of classes in the code.

Should we change the definition to String instead ?

@void0x23
Copy link
Author

void0x23 commented Nov 7, 2024

Also, in the api reference related to the knowledge_panels, the definition of the field action_element is String

Image
but seems to be returned as an object
Image
and this creates deserialization problems

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📚 OpenAPI 📦 Packaging https://wiki.openfoodfacts.org/Category:Recycling
Projects
Status: To discuss and validate
Status: Todo
Status: Todo
Status: To be triaged
Development

No branches or pull requests

2 participants