Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot login with a non-ASCII username #829

Closed
monsieurtanuki opened this issue Nov 17, 2023 · 3 comments
Closed

Cannot login with a non-ASCII username #829

monsieurtanuki opened this issue Nov 17, 2023 · 3 comments
Labels
🐛 bug Something isn't working 👥 user account

Comments

@monsieurtanuki
Copy link
Contributor

cf. openfoodfacts/smooth-app#4813
cf. https://openfoodfacts.sentry.io/issues/3458725816/?project=5376745&referrer=github_integration
Managed to reproduce the issue trying to connect (login2) as User(userId: 'លីវយី', password: '123')

Looks like the problem comes from From (haha) in the http header.
It's expected to be an email address (cf. https://datatracker.ietf.org/doc/html/rfc9110#name-from).
But we put there the user name.

Looks like only ASCII or ISO-8859-1 are 100% expected to work.

@g123k
Copy link
Contributor

g123k commented Nov 17, 2023

Correct me if I'm wrong, but it's more like a server issue than a Dart one?

@monsieurtanuki
Copy link
Contributor Author

Correct me if I'm wrong, but it's more like a server issue than a Dart one?

I don't think so, because WE are sending a header that is an INVALID http header, regardless of the server.
That said, there may be an impact on the off server side depending on the way they need/use From.
@teolemon @stephanegigandet do you guys need that From, e.g. for your stats, and would a base64 version of the From be good enough for you?

@monsieurtanuki
Copy link
Contributor Author

Fixed by #830.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working 👥 user account
Development

No branches or pull requests

3 participants