Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Server-side photo unselection #306

Closed
Tracked by #218
, #2427
...
teolemon opened this issue Nov 29, 2021 · 3 comments · Fixed by #319
Closed
Tracked by #218
, #2427
...

Add Server-side photo unselection #306

teolemon opened this issue Nov 29, 2021 · 3 comments · Fixed by #319
Assignees
@monsieurtanuki
Labels
🖼️ Photo management

Comments

@teolemon
Copy link
Member

teolemon commented Nov 29, 2021 •
edited
Loading

What

Add Server-side photo unselection
https://openfoodfacts.github.io/api-documentation/#jump-4WRITERequests-Deselectingaphoto

Part of
@teolemon teolemon mentioned this issue Nov 29, 2021
Open
@teolemon teolemon changed the title Server-side photo unselection https://openfoodfacts.github.io/api-documentation/#jump-4WRITERequests-Deselectingaphoto Add Server-side photo unselection Nov 29, 2021
@monsieurtanuki
Copy link
Contributor

@teolemon Not very verbose, is it?
Capture d’écran 2021-12-04 à 15 32 21

@teolemon teolemon mentioned this issue Dec 4, 2021
Open
1 task
@teolemon
Copy link
Member Author

teolemon commented Dec 4, 2021

thanks @monsieurtanuki , filed a documentation task at openfoodfacts/api-documentation#49 with the proper route

@monsieurtanuki monsieurtanuki self-assigned this Dec 14, 2021
@monsieurtanuki
Copy link
Contributor

It looks like https://world.openfoodfacts.net/cgi/product_image_unselect.pl?code=4250752200784&id=ingredients_de from what I read in

I'm about to PR.

monsieurtanuki added a commit to monsieurtanuki/openfoodfacts-dart that referenced this issue Dec 14, 2021
@monsieurtanuki
feat: openfoodfacts#306 - unselect product image
ea91655 
Impacted files:
* `api_addProductImage_test.dart`: new test about "unselect product image"
* `openfoodfacts.dart`: new method `unselectProductImage`
* `ProductImage.dart`: minor unrelated refactoring
monsieurtanuki added a commit to monsieurtanuki/openfoodfacts-dart that referenced this issue Dec 14, 2021
@monsieurtanuki
feat: openfoodfacts#306 - added "user" parameter to WRITE methods
4215573 
Impacted files:
* `api_addProductImage_test.dart`: added `User user` parameters when needed
* `openfoodfacts.dart`: added `User user` parameter to WRITE methods; added ending commas
@monsieurtanuki monsieurtanuki linked a pull request Dec 14, 2021 that will close this issue
feat: #306 - unselect product image #319
Merged
monsieurtanuki added a commit that referenced this issue Dec 15, 2021
@monsieurtanuki
feat: #306 - unselect product image, added "user" parameter to WRITE …
1c82e33 
…methods (#319)

Impacted files:
* `api_addProductImage_test.dart`: new test about "unselect product image"; refactored - added `User user` parameters when needed
* `openfoodfacts.dart`: new method `unselectProductImage`, added `User user` parameter to WRITE methods, added ending commas
* `ProductImage.dart`: minor unrelated refactoring
@teolemon teolemon mentioned this issue Jan 15, 2022
Closed
@teolemon teolemon mentioned this issue Jun 29, 2022
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@monsieurtanuki monsieurtanuki

Labels
🖼️ Photo management
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: #306 - unselect product image monsieurtanuki/openfoodfacts-dart
2 participants
@teolemon @monsieurtanuki