Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: remove 2U demographics collection #1077

Merged

Conversation

justinhynes
Copy link
Contributor

[APER-2823]

This PR removes functionality specific to 2U and edx.org from the Account MFE that was used for collecting demographics info from learners.

[APER-2823]

This PR removes functionality specific to 2U and edx.org from the Account MFE that was used for collecting demographics info from learners.
Copy link

codecov bot commented Jul 11, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 58.28%. Comparing base (c3d3022) to head (89d848e).

Files Patch % Lines
src/account-settings/data/service.js 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1077      +/-   ##
==========================================
+ Coverage   56.52%   58.28%   +1.76%     
==========================================
  Files         120      115       -5     
  Lines        2500     2330     -170     
  Branches      682      642      -40     
==========================================
- Hits         1413     1358      -55     
+ Misses       1012      911     -101     
+ Partials       75       61      -14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@jsnwesson jsnwesson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the cleanup, looks great!

@justinhynes justinhynes merged commit b0301d5 into master Jul 11, 2024
8 of 9 checks passed
@justinhynes justinhynes deleted the jhynes/APER-2823_remove-2U-demographics-collection branch July 11, 2024 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants