docs: split out "landing your work" section #472
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sarina
approved these changes
Feb 28, 2024
|
|
||
| All code in the pull request must be compatible with the Open edX project's AGPL | ||
| license. This means that the author of the pull request must sign a | ||
| `contributor's agreement`_, and all libraries included or |
There was a problem hiding this comment.
Suggested change
| `contributor's agreement`_, and all libraries included or | |
| `contributor's agreement`_ (or be covered by their employer's agreement), and all libraries included or |
Adding this because I know in the past we've had some slightly confused engineers at other companies submit a CLA when they don't need to.
| ------- | ||
|
|
||
| All of the tests must pass. You'll see the checks that are being run on the | ||
| bottom of your PR; they must be green. |
There was a problem hiding this comment.
| `Paragon pattern library`_. | ||
|
|
||
| ----------- | ||
| Code review |
There was a problem hiding this comment.
Suggested change
| Code review | |
| Code Review |
brian-smith-tcril
force-pushed
the
split-landing-work
branch
from
2dd2b05 to
0f5a938
Compare
|
👍🏻 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://docsopenedxorg--472.org.readthedocs.build/en/472/developers/references/developer_guide/process/landing-your-work.html