Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support to specify file permissions for pvc hostpaths #95

Open
kmova opened this issue Sep 1, 2021 · 6 comments · May be fixed by #157
Open

Add support to specify file permissions for pvc hostpaths #95

kmova opened this issue Sep 1, 2021 · 6 comments · May be fixed by #157
Assignees
@niladrih
Labels
work-in-progress Issue is being worked on.
Milestone
v4.2

Comments

@kmova
Copy link
Member

kmova commented Sep 1, 2021 •
edited
Loading

Describe the problem/challenge you have
Depending on the type of pods using the Local volumes, storage class should provide options to customize the permissions on the host path subdirectories. By default, the permissions are set to 0777.

Describe the solution you'd like
The customizations can be passed down via the StorageClass CAS config options.

Anything else you would like to add:
As part of this issue, we should explore options around:
@kmova kmova mentioned this issue Sep 1, 2021
Closed
@niladrih niladrih added SODACODE2022 SODACODE 2022 SODAMED and removed SODAMED labels Mar 3, 2022
@sushiMix
Copy link

sushiMix commented Jun 6, 2022

Hello, Is there some news about this ticket ?

This was referenced May 11, 2023
Closed
Open
@sushiMix
Copy link

Is this repository still maintained ? @niladrih ?

@niladrih
Copy link
Member

Is this repository still maintained ? @niladrih ?

Yes it is @sushiMix ! I'm sorry I haven't been able to take a look at your PR... I'll be reviewing it later today. Thank you for your contribution!

@sushiMix
Copy link

@niladrih Hello, any news ?

@niladrih
Copy link
Member

niladrih commented Oct 2, 2023

Hi @sushiMix. I'm sorry about the delay I have caused you. I've reviewed your PR. I'll repeat myself here as well:
An implementation for this feature exists in the openebs/dynamic-nfs-provisioner repo. PR link: openebs-archive/dynamic-nfs-provisioner#125

It'd be a good idea to use similar cas-config parameters. And even if we don't implement the API fully (i.e. include file-permissions along with file-mode), it'd be a good idea to use the same parameter names on the storageClass/PVC to keep the file-permissions API uniform across openebs storage engines. Wdyt?

@niladrih niladrih self-assigned this Oct 2, 2023
@sushiMix
Copy link

sushiMix commented Oct 2, 2023 •
edited
Loading

@niladrih thank you, I'll check to upgrade the PR.

I updated the code, it should import from Storage class and PVC by override. Need a bit of tests (before submitting the update of the PR) on my side and see later for user/group management (technically kubelet will perform the job as the PV is already using local path).

@niladrih niladrih added work-in-progress Issue is being worked on. and removed SODACODE2022 SODACODE 2022 SODAHIGH labels Jun 5, 2024
@avishnu avishnu added this to the v4.2 milestone Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@niladrih niladrih

Labels
work-in-progress Issue is being worked on.
Projects
None yet
Milestone
v4.2
4 participants
@avishnu @kmova @sushiMix @niladrih