Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More OO for templates #162

Open
mccalluc opened this issue Nov 15, 2024 · 0 comments
Open

More OO for templates #162

mccalluc opened this issue Nov 15, 2024 · 0 comments
Labels
nice-to-have No discussion required, but not top priority

Comments

@mccalluc
Copy link
Contributor

We have:

  • make_notebook_py
  • make_script_py

and

  • _make_context_for_notebook
  • _make_context_for_script

with a lot duplicated between the pairs of functions. Try to refactor this in a more OO way, with the shared logic in a super class.
@mccalluc mccalluc added the nice-to-have No discussion required, but not top priority label Nov 15, 2024
@github-project-automation github-project-automation bot moved this to Pending in DP Wizard Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
nice-to-have No discussion required, but not top priority
Projects
DP Wizard
Status: Pending
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mccalluc