Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature Request: GNMI Union Replace #124

Closed
mojiiba opened this issue Aug 12, 2023 · 4 comments
Closed

Feature Request: GNMI Union Replace #124

mojiiba opened this issue Aug 12, 2023 · 4 comments

Comments

@mojiiba
Copy link

mojiiba commented Aug 12, 2023

Could you please add support for GNMI Union Replace. The detail for gnmi union replace is described here: https://github.com/openconfig/reference/blob/master/rpc/gnmi/gnmi-union_replace.md
@mojiiba mojiiba changed the title Feature Request GNMI Union Replace Feature Request: GNMI Union Replace Aug 12, 2023
@greg-dennis
Copy link
Contributor

Heh, @wenovus fixed this very quickly earlier today in #123
What's left for Ondatra support:

  1. Pull this new ygnmi version into google3
  2. Add wrapper functions to Ondatra for BatchUnionReplace and BatchUnionReplaceCLI
  3. Push a new version of Ondatra externally
  4. Update featureprofiles deps to require the new Ondatra version

I am going on vacation for two weeks starting on Monday morning. @wenovus, can you take it from here?

@wenovus
Copy link
Contributor

wenovus commented Aug 14, 2023

Sure I can take a look.

@wenovus
Copy link
Contributor

wenovus commented Aug 14, 2023

Featureprofiles PR at openconfig/featureprofiles#2018

@mojiiba
Copy link
Author

mojiiba commented Aug 15, 2023

thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@greg-dennis @wenovus @mojiiba