Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: Improve observability in api-server metrics implementation #513

Open
aned opened this issue Aug 21, 2024 · 5 comments
Open
Labels
enhancement New feature or request

Comments

@aned
Copy link

aned commented Aug 21, 2024

This is a follow up on #498 , currently api-server /metrics implementation doesn't allow to properly monitor targets up/down.

api-server:
  address: :7890
  enable-metrics: true

Once the target becomes gnmi unreachable, the current metric gnmic_subscribe_number_of_received_subscribe_response_messages_total disappears.

There should be a deterministic way in /metrics to tell whether a target up or down.

@karimra
Copy link
Collaborator

karimra commented Nov 7, 2024

Should be added in v0.39.0, please give it a try.

@XioNoX
Copy link

XioNoX commented Nov 8, 2024

I'm not the initial requester but we've been waiting for it as well :)
Tested and works well for us. Thank you for implementing it !
Quick dashboard.

@hellt
Copy link
Collaborator

hellt commented Nov 8, 2024

oh, wow, Wikimedia uses gnmic then, @XioNoX ?

@XioNoX
Copy link

XioNoX commented Nov 8, 2024

Yep, we're only at the beginning, but it has been working very well for us so far. Thanks for the tool!
You can find more doc on https://wikitech.wikimedia.org/wiki/Network_telemetry

@aned
Copy link
Author

aned commented Nov 8, 2024

Nice, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants