Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit issue with compartmentless models #21

Open
phantomas1234 opened this issue Jan 6, 2014 · 3 comments
Open

Unit issue with compartmentless models #21

phantomas1234 opened this issue Jan 6, 2014 · 3 comments
Assignees
Labels

Comments

@phantomas1234
Copy link
Contributor

constructModel[{reaction["b1", {}, {metabolite["x1", None]}, {1}, False]}, Parameters -> {rateconst["b1", True] -> 0.1 Hour^-1}]

does not raise an error although the correct unit should be

rateconst["b1", True] -> 0.1 * Hour^-1 * Liter]

@ghost ghost assigned phantomas1234 Jan 6, 2014
@phantomas1234 phantomas1234 removed their assignment Jun 27, 2014
@avsastry avsastry self-assigned this Dec 3, 2014
@avsastry
Copy link
Contributor

avsastry commented Dec 3, 2014

Seems like this is a problem with the unit checking function in general. There is no error for either constructModel[{reaction["b1", {metabolite["x0", None]}, {metabolite["x1", None]}, {1, 1}, False]}, Parameters -> {rateconst["b1", True] -> 0.1*Hour^-1}, UnitChecking -> True] or constructModel[{reaction["b1", {metabolite["x0", None]}, {metabolite["x1", None]}, {1, 1}, False]}, Parameters -> {rateconst["b1", True] -> 0.1*Liter*Hour^-1}, UnitChecking -> True], even though only the first is correct.

@avsastry
Copy link
Contributor

avsastry commented Dec 3, 2014

Also, shouldn't the units of the compartmentless rate constant be Liter/(Mole*Hour)?

@phantomas1234
Copy link
Contributor Author

Its a tricky issue, although I've probably didn't intend this ambiguity,
both results are kinda ok (in the one case one ends up with a concentration
flux, in the other with a particle flux). Concentration fluxes are a
dangerous thing only in multi-compartment models but for no-compartment
models using both in the ODEs is fine I guess. Check out
http://www.copasi.org/tiki-download_file.php?fileId=73 for an explanation.
See also my notebook.

From what I can see, there should definitely be no quantity unit in the
rate constant's units because there is only one metabolite in the reaction,
right?

Best,

Niko

On Wed, Dec 3, 2014 at 9:53 AM, avsastry [email protected] wrote:

Also, shouldn't the units of the compartmentless rate constant be Liter *
Mole^-1 * Hour^-1?


Reply to this email directly or view it on GitHub
#21 (comment)
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants