Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New changes in the API RequestsLibrary #2105

Closed
gkeishin opened this issue Feb 24, 2021 · 6 comments
Closed

New changes in the API RequestsLibrary #2105

gkeishin opened this issue Feb 24, 2021 · 6 comments
Assignees

Comments

@gkeishin
Copy link
Member

gkeishin commented Feb 24, 2021

After making changes, I still see this, so will not push till all of these are resolve, else its flooding the logs and as well breaks those who are at lower level of package.

------------------------------------------------------------------------------
[ WARN ] Keyword 'RequestsLibrary.Post Request' is deprecated. Please use `POST On Session` instead.
[ WARN ] Keyword 'RequestsLibrary.Get Request' is deprecated. Please use `GET On Session` instead.
[ WARN ] Keyword 'RequestsLibrary.To Json' is deprecated. Please use ${resp.json()} instead. Have a look at the improved HTML output as pretty printing replacement.
[ WARN ] Ignoring space after '\n' is deprecated. For more info see: https://github.com/robotframework/robotframework/issues/3333
Test REST Setup :: Verify REST works.

new version for robotframework request API

https://marketsquare.github.io/robotframework-requests/doc/RequestsLibrary.html

@gkeishin gkeishin self-assigned this Feb 24, 2021
@gkeishin
Copy link
Member Author

old last working levels
robotframework-requests (0.7.0)
robotframework-requests (0.7.1)

new 

robotframework-requests (0.8.1)

@gkeishin
Copy link
Member Author

@gkeishin
Copy link
Member Author

Was trying some changes to check the behaviors and responses.. but looks like we may need to handle exception newly than response code.. have raised on ticket for it MarketSquare/robotframework-requests#322

let see..

@gkeishin
Copy link
Member Author

Need to work on this sooner :)

@gkeishin
Copy link
Member Author

gkeishin commented Aug 1, 2022

@gkeishin
Copy link
Member Author

gkeishin commented Aug 4, 2022

Robotframework requests package upgrade changes

Current working package version
robotframework-requests 0.7.2

To Test:

      pip3 install robotframework-requests -U
                 or
      # Once this commit is merged.
      pip3 install -r requirements.txt

      Version latest:
      robotframework-requests         0.9.3

Refer Documentation:
https://marketsquare.github.io/robotframework-requests/doc/RequestsLibrary.html

What is NOT changed:
- The test cases under directory tests/are not modified and is
deprecated but you can continue using it with an older package
and configuration using

   TODO: Awaiting a few more fixes before we branch out soon.
   git clone -b <THIS BRANCH>  https://github.com/openbmc/openbmc-test-automation

Tested:
Upstream HW_CI test list, firmware code update, and a few other
test suite like ipmi, certificate, dumps, ffdc, and redfish
test suites.

Note: I have not tested end to end, so it is likely there could be
grey areas where it could fail but should be minor w.r.t
response data format.

geissonator pushed a commit to openbmc/openbmc-build-scripts that referenced this issue Aug 17, 2022
Changes:
   - Requires this build script changes and code from test code
     https://gerrit.openbmc.org/c/openbmc/openbmc-test-automation/+/56052
   - Github task openbmc/openbmc-test-automation#2105
   - add robotframework-jsonlibrary package to replace deprecated
     keyword To JSON in test suites and resource files.

Tested: HW Jenkins test CI, code update, ffdc and few other test suites
        which are impacted due to this changes.

Change-Id: I73634fc3fd12ddd817d6016ebf156118d407fb24
Signed-off-by: George Keishing <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant