Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keyboard might overlap with video player in side by side mode #825

Open
mathebox opened this issue Sep 17, 2020 · 0 comments
Open

Keyboard might overlap with video player in side by side mode #825

mathebox opened this issue Sep 17, 2020 · 0 comments

Comments

@mathebox
Copy link
Member

Describe the bug
When in side-by-side mode and the keyboard is shown, the keyboard overlaps with the shown video.

To Reproduce
Steps to reproduce the behavior:

  1. Open a video item
  2. Switch to side-by-side mode with Notes app
  3. Tap into the notes canvas to show the keyboard
  4. Notice overlapping keyboard and video player

Expected behavior
Move the video up to show as much of the video as possible.

Screenshots
IMG_FCB5388DF46F-1

Affected Component
BingePlayerViewController

Additional context

  • Observe UIResponder.keyboardWillShowNotification and UIResponder.keyboardWillHideNotification to react accordingly.
  • Retrieve height for keyboard via

    let keyboardFrameValue = notification.userInfo[UIResponder.keyboardFrameEndUserInfoKey] as? NSValuelet keyboardHeight = keyboardFrameValue?.cgRectValue.size.height
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant